-
Notifications
You must be signed in to change notification settings - Fork 360
DO NOT MERGE: Click UI test #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add @punkbit/cui and styled-components dependencies - Integrate ClickUIProvider alongside MantineProvider in ThemeWrapper - Both providers share the same colorScheme for consistent theming
…mproved styling and functionality - Replace Textarea with TextAreaField from @punkbit/cui in AutocompleteInput - Refactor Popover component usage for better accessibility and styling - Simplify SearchInputV2 by removing unnecessary Group component for the Docs link - Introduce ClickUIThemeVars component to inject Click UI theme values as CSS variables - Update semantic colors to utilize Click UI CSS variables for dynamic theming
…ility - Introduced a new document detailing issues and limitations when migrating from Mantine UI to Click UI components. - Updated `DBSearchPage.tsx` to replace Mantine components with Click UI equivalents, addressing known issues such as icon prop types and button behavior. - Added a new `ClickStackLogo` component to replace the deprecated `Icon` component across various files. - Adjusted styles in `AppNav` and other components to align with Click UI standards.
- Added new versions of `@punkbit/cui`, `styled-components`, and other related packages in `yarn.lock` and `package.json`. - Updated import paths in various components to directly use `@punkbit/cui` instead of the deprecated `/bundled` path. - Enhanced `AutocompleteInput` to address `Popover.Trigger` width issues and ensure proper styling in flex layouts. - Documented known issues and workarounds in migration notes for Click UI components.
- Prevent Popover.Trigger from toggling on click to manage open state via focus. - Add event handlers to prevent default actions on auto-focus and mouse down events for better control. - Improve user experience by ensuring suggestions and history selections do not trigger unintended actions.
…sues - Added a note indicating that the Click UI Select component is not migrated due to dropdown functionality issues. - Documented the current workaround using Mantine Select and outlined attempted approaches to resolve the issue. - Updated `SelectControlled.tsx` to reflect the decision to retain Mantine Select until Click UI Select is functional. - Adjusted migration notes to include a new search tag for the Select component issue.
- Updated @punkbit/cui to version 0.0.251-rc.16 in package.json. - Adjusted various package versions in yarn.lock, including @babel/runtime, styled-components, react-syntax-highlighter, and others for improved compatibility and performance.
…ect and TextField - Replaced the Mantine Select component with CUISelect in DBSearchPage for live tail refresh frequency selection. - Updated TimePicker component to use TextField instead of TextInput, enhancing the input handling and styling. - Improved event handling for the TextField to support Enter and Escape key actions.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review - Click UI Migration TestCritical Issues
Observations✅ Migration documentation is thorough and transparent about Click UI limitations RecommendationThe
Note: This appears to be marked as a test PR - if this is exploratory work not intended for production, some issues may be acceptable for evaluation purposes. |
E2E Test Results❌ 2 tests failed • 58 passed • 4 skipped • 999s
Tests ran across 4 shards in parallel. |
- Changed import statements for ClickStackLogo in Logo, OnboardingChecklist, and Spotlights components to use named exports. - This improves consistency and aligns with the updated module structure.
- Changed the import statement in the Logo component to use ClickStackIcon instead of ClickStackLogo, aligning with the updated module structure.
|
@copilot can you replace the package |
|
@elizabetdev I've opened a new pull request, #1642, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elizabetdev <2750668+elizabetdev@users.noreply.github.com>
|
@copilot can you replace the package @clickhouse/click-ui@0.0.251-rc.16 with @clickhouse/click-ui@0.0.251-rc.17 |
|
@elizabetdev I've opened a new pull request, #1679, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elizabetdev <2750668+elizabetdev@users.noreply.github.com>
…ker component - Removed duplicate import of TextField from @clickhouse/click-ui. - Added type safety comments for onChange and onKeyDown handlers to address TypeScript errors.
- Eliminated outdated TypeScript error comments for onChange and onKeyDown handlers in the TimePicker component to improve code clarity and maintainability.
🔗 Preview
View Vercel Preview →
Summary
This PR tests replacing Mantine UI components with Click UI components to evaluate compatibility and identify migration issues.