Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0061143 to
a4ede74
Compare
Collaborator
|
@kunalpanchal are you able to find some time in your AM to test this? |
elizabetdev
approved these changes
Jan 30, 2026
Member
elizabetdev
left a comment
There was a problem hiding this comment.
Tested in HyperDX here, and it works as expected.
LGTM! 🎉
Collaborator
|
Apart from the minor type error mentioned above, everything else looks and works fine on control-plane. |
kunalpanchal
approved these changes
Feb 2, 2026
Collaborator
Author
Just to avoid confusion, this is not shipping a type error! The change is a requirement due to a small deprecation in the context menu as described in the changeset here https://github.com/ClickHouse/click-ui/pull/756/changes#diff-801534275d6fc19b60543371f1055838e7d60942fa4005c3ab1623293e10fb7fR24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
TLDR; Click-UI fails to install, run or build on major React-like libraries, e.g. HyperDX, Nextjs, Vitejs latest. The PR provides a minimal set of changes to unblock the team.
The current/latest versions of click-ui, such as https://www.npmjs.com/package/@clickhouse/click-ui/v/0.0.250, break on the latest of Nextjs, Vitejs, any React >= 19 or RSC enabled builds. To mitigate it, this initial PR provides the minimal setup required for it to work in such environments, e.g. when installing the package, it should run in dev and build processes. It does NOT try to modify, replace, introduce or change breaking changes. At the time of writing, the library requires a browser runtime, being client-only. Separately, there'll be other PR to address other related concerns and expand on this initial PR, e.g. none interactive components shall render server-side.
A version is provided as:
https://www.npmjs.com/package/@clickhouse/click-ui/v/0.0.251-rc.17
How?
Demo?
demo-cui-nextjs-latest-build-output.mp4
demo-cui-nextjs-v16-latest.mp4
demo-cui-vite-latest.mp4
demo-cui-nextjs-v16-latest.mp4