Merged
Conversation
Migrate from internal pkg/env to toolhive-core/env as the third adoption from the shared library per THV-0032. The env package provides a testable abstraction for environment variable access via the Reader interface and OSReader implementation, along with generated mocks for testing. - Replace pkg/env imports with toolhive-core/env - Replace pkg/env/mocks imports with toolhive-core/env/mocks - Remove internal pkg/env package Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
==========================================
+ Coverage 65.47% 65.52% +0.05%
==========================================
Files 403 403
Lines 39633 39779 +146
==========================================
+ Hits 25951 26067 +116
- Misses 11678 11700 +22
- Partials 2004 2012 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
approved these changes
Feb 3, 2026
dmjb
approved these changes
Feb 4, 2026
ChrisJBurns
approved these changes
Feb 4, 2026
Collaborator
ChrisJBurns
left a comment
There was a problem hiding this comment.
Always love seeing a 🔴 diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third adoption from the shared
toolhive-corelibrary per THV-0032 RFC.The
envpackage provides a testable abstraction for environment variable access:Readerinterface for dependency injectionOSReaderimplementation wrappingos.GetenvAPI Changes
No functional changes - the API is identical.
Test plan
task lintpasses🤖 Generated with Claude Code