Wilcoxon rank-sum addition to rank_genes_groups#487
Closed
EriJFle wants to merge 6 commits intoscverse:mainfrom
Closed
Wilcoxon rank-sum addition to rank_genes_groups#487EriJFle wants to merge 6 commits intoscverse:mainfrom
EriJFle wants to merge 6 commits intoscverse:mainfrom
Conversation
|
when will this function merged, thanks a lot, very needed |
|
does it mean it fully support the Wilcoxon rank-sum on gpu? |
Member
|
@EriJFle great work on this. #535 is the PR that will be merged. It's based on your branch so your initial contributions will still be in the codebase. I also added your name to the release note. I made this even faster and more memory efficient on CPU and GPU. I also the option to define a reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This work introduces a CuPy-based GPU implementation of the Wilcoxon rank-sum test for rank_genes_groups().
Key changes
GPU acceleration: Rank computation, group rank sums, z-scores, and two-sided p-values are computed on the GPU (CuPy + cupyx.scipy.special.ndtr).
Vectorized group operations: Replace per-group loops with a single matrix multiply
group_matrix.T @ ranksto obtain all group rank sums at once.GPU-native rank computation: Mid-ranks and tie-correction implemented via CuPy primitives (cp.argsort, cp.cumsum) to mirror Scanpy semantics.
Dynamic GPU memory management:
_choose_chunk_size()queriescp.cuda.runtime.memGetInfo()to size gene chunks adaptively (avoids OOM and maximizes throughput).Testing:
Added
tests/test_rank_genes_groups_wilcoxon.pyto ensure same output as Scanpy’s wilcoxon rank_genes_groups.