Skip to content

fix: custom exclude filter crashes when custom imports is set but custom exclude is not #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimisola merged 2 commits into from
Mar 1, 2026
Merged

fix: custom exclude filter crashes when custom imports is set but custom exclude is not #234

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42368f7
fix: custom exclude filter crashes when custom imports is set but cus…
jimisola Feb 28, 2026
c8b1b5c
Merge branch 'main' into fix/custom-exclude-guard-233
jimisola Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/reqstool/model_generators/combined_indexed_dataset_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ def __get_filtered_out_requirements_for_filter_urn( # noqa C901 # NOSONAR
)
# compute lark_tree if custom exclude exists
tree_custom_exclude = (
None if req_filter.custom_imports is None else RequirementsELTransformer.parse_el(req_filter.custom_exclude)
None if req_filter.custom_exclude is None else RequirementsELTransformer.parse_el(req_filter.custom_exclude)
)

# iterate over _all accessible_ requirements
Expand Down Expand Up @@ -539,7 +539,7 @@ def __get_filtered_out_svcs_for_filter_urn( # noqa C901 # NOSONAR
)
# compute lark_tree if custom exclude exists
tree_custom_exclude = (
None if svc_filter.custom_imports is None else SVCsELTransformer.parse_el(svc_filter.custom_exclude)
None if svc_filter.custom_exclude is None else SVCsELTransformer.parse_el(svc_filter.custom_exclude)
)

# iterate over _all accessible_ svcs
Expand Down