fix: custom exclude filter crashes when custom imports is set but custom exclude is not#234
Open
fix: custom exclude filter crashes when custom imports is set but custom exclude is not#234
Conversation
…tom exclude is not The guard condition for building the custom exclude expression tree checked custom_imports is None instead of custom_exclude is None in both __get_filtered_out_requirements_for_filter_urn and __get_filtered_out_svcs_for_filter_urn. When custom_imports was set but custom_exclude was absent, parse_el(None) was called, causing a runtime crash. Fixes #233, refs #222.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_el(None)was called whencustom_importswas set butcustom_excludewas absentcustom_imports is Noneinstead ofcustom_exclude is Nonein two places — a copy-paste error affecting both__get_filtered_out_requirements_for_filter_urnand__get_filtered_out_svcs_for_filter_urnFixes #233, refs #222.
Test plan
94 passed)custom_importsset but nocustom_exclude