[CODE HEALTH] Fix clang-tidy warnings, part 1.

api/include/opentelemetry/nostd/variant.h

@@ -27,7 +27,7 @@ namespace nostd
 class bad_variant_access : public std::exception
 {
 public:
-  virtual const char *what() const noexcept override { return "bad_variant_access"; }
+  const char *what() const noexcept override { return "bad_variant_access"; }
 };
 
 [[noreturn]] inline void throw_bad_variant_access()

examples/grpc/tracer_common.h

@@ -32,14 +32,14 @@ class GrpcClientCarrier : public opentelemetry::context::propagation::TextMapCar
 public:
   GrpcClientCarrier(ClientContext *context) : context_(context) {}
   GrpcClientCarrier() = default;
-  virtual opentelemetry::nostd::string_view Get(
+  opentelemetry::nostd::string_view Get(
       opentelemetry::nostd::string_view /* key */) const noexcept override
   {
     return "";
   }
 
-  virtual void Set(opentelemetry::nostd::string_view key,
-                   opentelemetry::nostd::string_view value) noexcept override
+  void Set(opentelemetry::nostd::string_view key,
+           opentelemetry::nostd::string_view value) noexcept override
   {
     std::cout << " Client ::: Adding " << key << " " << value << "\n";
     context_->AddMetadata(std::string(key), std::string(value));
@@ -53,7 +53,7 @@ class GrpcServerCarrier : public opentelemetry::context::propagation::TextMapCar
 public:
   GrpcServerCarrier(ServerContext *context) : context_(context) {}
   GrpcServerCarrier() = default;
-  virtual opentelemetry::nostd::string_view Get(
+  opentelemetry::nostd::string_view Get(
       opentelemetry::nostd::string_view key) const noexcept override
   {
     auto it = context_->client_metadata().find({key.data(), key.size()});
@@ -64,8 +64,8 @@ class GrpcServerCarrier : public opentelemetry::context::propagation::TextMapCar
     return "";
   }
 
-  virtual void Set(opentelemetry::nostd::string_view /* key */,
-                   opentelemetry::nostd::string_view /* value */) noexcept override
+  void Set(opentelemetry::nostd::string_view /* key */,
+           opentelemetry::nostd::string_view /* value */) noexcept override
   {
     // Not required for server
   }

examples/http/server.h

@@ -50,7 +50,7 @@ class HttpServer : public HTTP_SERVER_NS::HttpRequestCallback
     }
   }
 
-  ~HttpServer() { Stop(); }
+  ~HttpServer() override { Stop(); }
 };
 
 }  // namespace

examples/http/tracer_common.h

@@ -31,7 +31,7 @@ class HttpTextMapCarrier : public opentelemetry::context::propagation::TextMapCa
 public:
   HttpTextMapCarrier(T &headers) : headers_(headers) {}
   HttpTextMapCarrier() = default;
-  virtual opentelemetry::nostd::string_view Get(
+  opentelemetry::nostd::string_view Get(
       opentelemetry::nostd::string_view key) const noexcept override
   {
     std::string key_to_compare = key.data();
@@ -53,8 +53,8 @@ class HttpTextMapCarrier : public opentelemetry::context::propagation::TextMapCa
     return "";
   }
 
-  virtual void Set(opentelemetry::nostd::string_view key,
-                   opentelemetry::nostd::string_view value) noexcept override
+  void Set(opentelemetry::nostd::string_view key,
+           opentelemetry::nostd::string_view value) noexcept override
   {
     headers_.insert(std::pair<std::string, std::string>(std::string(key), std::string(value)));
   }

exporters/memory/include/opentelemetry/exporters/memory/in_memory_span_exporter.h

@@ -75,10 +75,7 @@ class InMemorySpanExporter final : public opentelemetry::sdk::trace::SpanExporte
     return sdk::common::ExportResult::kSuccess;
   }
 
-  virtual bool ForceFlush(std::chrono::microseconds /* timeout */) noexcept override
-  {
-    return true;
-  }
+  bool ForceFlush(std::chrono::microseconds /* timeout */) noexcept override { return true; }
 
   /**
    * Attempt to shut down the in-memory span exporter.

ext/include/opentelemetry/ext/http/server/http_server.h

@@ -238,7 +238,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
   void stop() { m_reactor.stop(); }
 
 protected:
-  virtual void onSocketAcceptable(SocketTools::Socket socket) override
+  void onSocketAcceptable(SocketTools::Socket socket) override
   {
     LOG_TRACE("HttpServer: accepting socket fd=0x%llx", socket.m_sock);
     assert(std::find(m_listeningSockets.begin(), m_listeningSockets.end(), socket) !=
@@ -258,7 +258,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
     }
   }
 
-  virtual void onSocketReadable(SocketTools::Socket socket) override
+  void onSocketReadable(SocketTools::Socket socket) override
   {
     LOG_TRACE("HttpServer: reading socket fd=0x%llx", socket.m_sock);
     // No thread-safety here!
@@ -286,7 +286,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
     handleConnection(conn);
   }
 
-  virtual void onSocketWritable(SocketTools::Socket socket) override
+  void onSocketWritable(SocketTools::Socket socket) override
   {
     LOG_TRACE("HttpServer: writing socket fd=0x%llx", socket.m_sock);
 
@@ -308,7 +308,7 @@ class HttpServer : private SocketTools::Reactor::SocketCallback
     }
   }
 
-  virtual void onSocketClosed(SocketTools::Socket socket) override
+  void onSocketClosed(SocketTools::Socket socket) override
   {
     LOG_TRACE("HttpServer: closing socket fd=0x%llx", socket.m_sock);
     assert(std::find(m_listeningSockets.begin(), m_listeningSockets.end(), socket) ==

ext/include/opentelemetry/ext/http/server/socket_tools.h

@@ -700,7 +700,7 @@ struct Reactor : protected common::Thread
   /// <summary>
   /// Thread Loop for async events processing
   /// </summary>
-  virtual void onThread() override
+  void onThread() override
   {
     LOG_INFO("Reactor: Thread started");
     while (!shouldTerminate())

sdk/include/opentelemetry/sdk/metrics/state/multi_metric_storage.h

@@ -30,37 +30,35 @@ class SyncMultiMetricStorage : public SyncWritableMetricStorage
     storages_.push_back(storage);
   }
 
-  virtual void RecordLong(int64_t value,
-                          const opentelemetry::context::Context &context) noexcept override
+  void RecordLong(int64_t value, const opentelemetry::context::Context &context) noexcept override
   {
     for (auto &s : storages_)
     {
       s->RecordLong(value, context);
     }
   }
 
-  virtual void RecordLong(int64_t value,
-                          const opentelemetry::common::KeyValueIterable &attributes,
-                          const opentelemetry::context::Context &context) noexcept override
+  void RecordLong(int64_t value,
+                  const opentelemetry::common::KeyValueIterable &attributes,
+                  const opentelemetry::context::Context &context) noexcept override
   {
     for (auto &s : storages_)
     {
       s->RecordLong(value, attributes, context);
     }
   }
 
-  virtual void RecordDouble(double value,
-                            const opentelemetry::context::Context &context) noexcept override
+  void RecordDouble(double value, const opentelemetry::context::Context &context) noexcept override
   {
     for (auto &s : storages_)
     {
       s->RecordDouble(value, context);
     }
   }
 
-  virtual void RecordDouble(double value,
-                            const opentelemetry::common::KeyValueIterable &attributes,
-                            const opentelemetry::context::Context &context) noexcept override
+  void RecordDouble(double value,
+                    const opentelemetry::common::KeyValueIterable &attributes,
+                    const opentelemetry::context::Context &context) noexcept override
   {
     for (auto &s : storages_)
     {

sdk/include/opentelemetry/sdk/trace/multi_span_processor.h

@@ -73,8 +73,8 @@ class MultiSpanProcessor : public SpanProcessor
     return recordable;
   }
 
-  virtual void OnStart(Recordable &span,
-                       const opentelemetry::trace::SpanContext &parent_context) noexcept override
+  void OnStart(Recordable &span,
+               const opentelemetry::trace::SpanContext &parent_context) noexcept override
   {
     auto multi_recordable = static_cast<MultiRecordable *>(&span);
     ProcessorNode *node   = head_;
@@ -90,7 +90,7 @@ class MultiSpanProcessor : public SpanProcessor
     }
   }
 
-  virtual void OnEnd(std::unique_ptr<Recordable> &&span) noexcept override
+  void OnEnd(std::unique_ptr<Recordable> &&span) noexcept override
   {
     auto multi_recordable = static_cast<MultiRecordable *>(span.release());
     ProcessorNode *node   = head_;