Skip to content

[CODE HEALTH] Fix clang-tidy warnings, part 1.#3841

Merged
marcalff merged 2 commits intoopen-telemetry:mainfrom
marcalff:tidy_explicit_virtual_functions
Feb 3, 2026
Merged

[CODE HEALTH] Fix clang-tidy warnings, part 1.#3841
marcalff merged 2 commits intoopen-telemetry:mainfrom
marcalff:tidy_explicit_virtual_functions

Conversation

@marcalff
Copy link
Member

@marcalff marcalff commented Feb 3, 2026

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Fixes cppcoreguidelines-explicit-virtual-functions warnings.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff marked this pull request as ready for review February 3, 2026 08:11
@marcalff marcalff requested a review from a team as a code owner February 3, 2026 08:11
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.96%. Comparing base (46e7619) to head (4cc8ddf).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/include/opentelemetry/nostd/variant.h 0.00% 1 Missing ⚠️
...lemetry/exporters/memory/in_memory_span_exporter.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
+ Coverage   89.95%   89.96%   +0.02%     
==========================================
  Files         225      225              
  Lines        7170     7169       -1     
==========================================
  Hits         6449     6449              
+ Misses        721      720       -1     
Files with missing lines Coverage Δ
...telemetry/sdk/metrics/state/multi_metric_storage.h 100.00% <100.00%> (ø)
...ude/opentelemetry/sdk/trace/multi_span_processor.h 100.00% <100.00%> (ø)
api/include/opentelemetry/nostd/variant.h 66.67% <0.00%> (ø)
...lemetry/exporters/memory/in_memory_span_exporter.h 85.00% <0.00%> (+4.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

@marcalff marcalff merged commit 437ad43 into open-telemetry:main Feb 3, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants