test: add tests for all tools by barrettruth · Pull Request #76 · nvimdev/guard-collection

barrettruth · 2026-02-06T19:29:51Z

Adds test coverage for ALL formatters and linters using the revamped architecture.

New tools tested in this PR: literally all remaining ones
update Makefile with new CI job categories

closes #67 (6-7 reference)

xiaoshihou514 · 2026-02-07T00:16:56Z

Please don't change the config unless it's really incompatible with the tool's latest stable... If you really need to, leave a note in the pr so that I can verify 🙏.

barrettruth · 2026-02-07T00:38:17Z

Note that after this pr gets rebased onto main after the other ones are merged, the only config change made was the -e flag in ruff - which has been deprecated (actually, it doesn't even work) in favor of check. So low key it's a prerequisite for this code & test to pass for ruff.

lua/guard-collection/formatter.lua

barrettruth · 2026-02-08T21:54:04Z

done. r4r! @xiaoshihou514

xiaoshihou514 · 2026-02-08T22:50:20Z

For jar releases, I think there's sdk man that provides you with a single executable (dunno if that's through graal or a wrapper).

xiaoshihou514 · 2026-02-08T22:58:29Z

For lint specs, it should actually use the configs instead of recreating the command again.

xiaoshihou514 · 2026-02-08T22:59:24Z

In the workflow file, luarocks, vim setup etc was repeated many times. Could you investigate if there's a way to refactor this?

xiaoshihou514 · 2026-02-09T09:00:08Z

Blocked by comments above for now :)

Problem: most formatters and linters in guard-collection had no test coverage. The csharpier binary was renamed in v1.0+ and ruff's -e flag was deprecated in favor of the check subcommand. Solution: add 42 test files covering every remaining tool, fix the csharpier and ruff definitions, extend the install script with gz/jar archive types, add 6 new CI jobs (dotnet, ruby, clojure, elixir, nix, swift), and expand existing jobs with newly tested tools.

Problem: the -X theirs merge strategy replaced the full test/all-tools CI config with the smaller fix/broken-configs version, losing install entries for dart, fish_indent, google-java-format, pg_format, tombi, typos, typstyle, xmllint, and zigfmt. Solution: restore binary.txt, ci.yaml, and install script from the pre-merge test/all-tools state which already had all entries.

Problem: every test job repeated the same 5 steps for neovim, lua, luarocks, busted/nlua, and guard.nvim clone — 175 lines of duplication across 15 jobs. Solution: extract into .github/actions/test-setup/action.yml and replace with a single `uses: ./.github/actions/test-setup` per job.

Problem: rebase picked up old test versions that manually construct commands instead of using the config-driven helpers, defeating the purpose of testing the actual tool definitions. Solution: replace all 14 affected test files with the upstream/main versions that use run_lint/run_fmt. Add buf lint test using run_lint.

barrettruth · 2026-02-09T17:39:49Z

we are now reusing the configs across all (EXCEPT for fn = -like linters, an issue is open for that now, including cpplint, prettierd, zsh)
i deem sdkman to NOT be worth it because ktfmt, ktlint, and google-java-format are not available (ktlint was even removed)
about the workflows, great point. i've made a refactor. see if you like it - I think it's way better!

@xiaoshihou514

xiaoshihou514 · 2026-02-09T17:55:02Z

It's much cleaner now, I think it's almost ready :)

cljfmt: probably best to use their install script
Long apt install cmd somewhere
I haven't looked at the linters yet

barrettruth · 2026-02-09T18:28:27Z

Just addressed both:

cljfmt: Switched to the standalone binary from their github release, it's now in binary.txt
apt packages have been extracted to .github/tools/binary-apt.txt, read via xargs like the other tool lists.

xiaoshihou514 · 2026-02-09T19:27:05Z

https://github.com/barrettruth/guard-collection/blob/test%2Fall-tools/.github%2Fworkflows%2Fci.yaml#L116-L116

Problem: cljfmt required a dedicated CI job with Java, Clojure CLI, a hand-rolled wrapper script, and dep pre-warming. The binary job also had an inline apt-get install command inconsistent with other tool lists. Solution: switch cljfmt to the standalone GraalVM binary from GitHub releases, move its test into test/binary/, delete the test-clojure job, and extract the binary job's apt packages into binary-apt.txt.

barrettruth · 2026-02-09T19:40:02Z

sorry... fixed!

accidentally applied commits to #81

Tests failing because of github actions being down (AGAIN!)

xiaoshihou514 · 2026-02-08T22:54:04Z

.github/workflows/ci.yaml

+      - name: Install tools
+        run: |
+          mkdir -p $HOME/.local/bin
+          printf '#!/bin/sh\nclojure -Sdeps '"'"'{:deps {dev.weavejester/cljfmt {:mvn/version "0.13.0"}}}'"'"' -M -m cljfmt.main "$@"\n' > $HOME/.local/bin/cljfmt && chmod +x $HOME/.local/bin/cljfmt


What? Surely there's a better way. Maybe through clojure's pm lein?

.github/workflows/ci.yaml

xiaoshihou514 · 2026-02-08T22:55:02Z

.github/workflows/ci.yaml

+          printf "source 'https://rubygems.org'\ngem 'rubocop'\n" > /tmp/rubocop-test/Gemfile
+          cd /tmp/rubocop-test && bundle install


Same, probably a way to install it globally.

xiaoshihou514 · 2026-02-08T22:55:41Z

.github/workflows/ci.yaml

+      - name: Pre-warm cljfmt deps
+        run: |
+          export PATH="$HOME/.local/bin:$PATH"
+          echo "" | cljfmt fix - || true


This is such a hack... See above.

xiaoshihou514 · 2026-02-08T22:57:15Z

test/binary/cbfmt_spec.lua

@@ -0,0 +1,25 @@
+describe('cbfmt', function()


Why doesn't this use test.helper?

.github/workflows/ci.yaml

xiaoshihou514 · 2026-02-10T15:41:14Z

https://github.com/barrettruth/guard-collection/blob/test%2Fall-tools/.github%2Fworkflows%2Fci.yaml#L163-L165

Can it be installed globally? (I know the config uses pm to launch it)

Problem: rubocop formatter and linter definitions used `bundle exec rubocop`, requiring a Gemfile and bundle install in both tests and CI. Solution: invoke rubocop directly via `gem install rubocop`. Remove Gemfile setup from test and CI.

barrettruth · 2026-02-10T18:17:48Z

cbfmt uses run_* test function, cljfmt & rubocop installation updated, unecessary pre-warm step removed.

anything else? if not, feel free to merge

(once again, i don't have permission)

xiaoshihou514 · 2026-02-10T20:57:57Z

yep

barrettruth mentioned this pull request Feb 6, 2026

Add test coverage check script and CI job #77

Closed

barrettruth marked this pull request as ready for review February 6, 2026 23:36

xiaoshihou514 reviewed Feb 7, 2026

View reviewed changes

lua/guard-collection/formatter.lua Show resolved Hide resolved

xiaoshihou514 reviewed Feb 7, 2026

View reviewed changes

lua/guard-collection/formatter.lua Show resolved Hide resolved

barrettruth commented Feb 7, 2026

View reviewed changes

lua/guard-collection/formatter.lua Show resolved Hide resolved

barrettruth force-pushed the test/all-tools branch 2 times, most recently from 472fe62 to 83fb825 Compare February 8, 2026 21:42

barrettruth commented Feb 8, 2026

View reviewed changes

lua/guard-collection/formatter.lua Show resolved Hide resolved

barrettruth requested a review from xiaoshihou514 February 8, 2026 22:39

barrettruth mentioned this pull request Feb 9, 2026

fix: correct broken tool definitions #79

Merged

barrettruth force-pushed the test/all-tools branch 3 times, most recently from 6d888e5 to e70d673 Compare February 9, 2026 06:22

barrettruth added 4 commits February 9, 2026 12:32

fix(ci): remove duplicate entry and untestable mypyc test

8b45336

barrettruth force-pushed the test/all-tools branch from 409ff5b to 564e321 Compare February 9, 2026 17:32

barrettruth added 3 commits February 9, 2026 14:48

ci: retrigger

2625efc

ci: retrigger

9b71300

ci: re-trigger

4b63ee2

xiaoshihou514 approved these changes Feb 10, 2026

View reviewed changes

barrettruth requested a review from xiaoshihou514 February 10, 2026 18:18

xiaoshihou514 merged commit ea1d770 into nvimdev:main Feb 10, 2026
13 checks passed

		printf "source 'https://rubygems.org'\ngem 'rubocop'\n" > /tmp/rubocop-test/Gemfile
		cd /tmp/rubocop-test && bundle install

Conversation

barrettruth commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoshihou514 commented Feb 7, 2026

Uh oh!

barrettruth commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barrettruth commented Feb 8, 2026

Uh oh!

xiaoshihou514 commented Feb 8, 2026

Uh oh!

xiaoshihou514 commented Feb 8, 2026

Uh oh!

xiaoshihou514 commented Feb 8, 2026

Uh oh!

xiaoshihou514 commented Feb 9, 2026

Uh oh!

barrettruth commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoshihou514 commented Feb 9, 2026

Uh oh!

barrettruth commented Feb 9, 2026

Uh oh!

xiaoshihou514 commented Feb 9, 2026

Uh oh!

barrettruth commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoshihou514 Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xiaoshihou514 Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

xiaoshihou514 Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

xiaoshihou514 Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

xiaoshihou514 commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

barrettruth commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaoshihou514 commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

barrettruth commented Feb 6, 2026 •

edited

Loading

barrettruth commented Feb 7, 2026 •

edited

Loading

barrettruth commented Feb 9, 2026 •

edited

Loading

barrettruth commented Feb 9, 2026 •

edited

Loading

xiaoshihou514 commented Feb 10, 2026 •

edited

Loading

barrettruth commented Feb 10, 2026 •

edited

Loading