fix: correct broken tool definitions#79
Merged
xiaoshihou514 merged 2 commits intonvimdev:mainfrom Feb 9, 2026
Merged
Conversation
barrettruth
force-pushed
the
fix/broken-configs
branch
3 times, most recently
from
4fb30fd to
d0fa7a6
Compare
Problem: several formatter and linter configs produced invalid commands when invoked by guard.nvim. pylint, shellcheck, and rubocop were missing fname=true so guard never appended the required filename argument. hadolint lacked the '-' arg needed to read stdin. ruff linter used the deprecated -e flag and was missing the 'check' subcommand. buf format was configured for stdin which it does not support. csharpier referenced the old dotnet-csharpier binary renamed in v1.0+. ruff_fix was missing the 'check' subcommand. Solution: add fname=true to pylint, shellcheck, and rubocop linters. Add '-' to hadolint args. Replace ruff linter's -e with check subcommand. Change buf from stdin to fname with -w flag. Update csharpier cmd and args for v1.0+. Add check to ruff_fix args.
barrettruth
force-pushed
the
fix/broken-configs
branch
3 times, most recently
from
ca21a43 to
bdfcf86
Compare
Problem: the config fixes in the previous commit had no test coverage proving the definitions produce valid commands. Solution: add opts (cwd, tmpdir) and assert_diag to the test helper. Add tests for all 8 fixed tools using run_fmt/run_lint to exercise the actual configs. Add pylint to pip.txt, hadolint to binary.txt, shellcheck to the binary CI job, and new test-dotnet and test-ruby CI jobs.
barrettruth
force-pushed
the
fix/broken-configs
branch
from
bdfcf86 to
dc5209b
Compare
Member
|
Looks reasonable, but all the problems I addressed before still holds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Many tool definitions produce invalid commands when invoked, such as:
fname = true-to read stdin-eflag and is missing thechecksubcommanddotnet-csharpierbinary and is missing theformatsubcommandSolution
Fix all configs and add a test for each one that exercises the
definition through
run_fmt/run_lintas you suggested, so the configs are actuallyproven to work. The test helper gains
opts(cwd/tmpdir) andassert_diagto support this. Finally, CI picks up pylint, hadolint,shellcheck, dart, and two new jobs for dotnet and ruby.
This is a prerequisite for #76. I figured that it'd be better to fix these FIRST then add the rest of the tests to make it clear which linters/formatters are presently BROKEN vs. which we're just adding tests for.