chore: k8s_setup.sh should use kubectl wait
#168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been over 5 years since the current logic to wait on clusters was contributed. Better to use `kubectl wait` now. This will also better convey failure when `kubectl` is not a valid binary. Signed-off-by: Brennan Kinney <[email protected]>
This was referenced Nov 8, 2025
SuperQ
approved these changes
Nov 8, 2025
Contributor
|
Thanks, yea, this whole setup hasn't been maintained in a while. If you're willing to work on things, we could use the contributions. |
Contributor
|
Let's see if #169 fixes the test failure. |
Contributor
Author
I would if I could spare the time 😅 Huge OSS backlog to work through myself. I'm mostly providing drive-by contributions related to making CI happy for a CoreDNS PR I have been trying to push for over 2 years now 😆 (which should be more acceptable with containerd 2.0 adoption and other ecosystem changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been over 5 years since the current logic to wait on clusters was contributed. Better to use
kubectl waitnow (originally suggested here).This will also better convey failure when
kubectlis not a valid binary (example).Given the script hasn't been updated in over 5 years however, I'm not sure how relevant the
clusterrolespatch is now? (I lack familiarity with how to go about checking if that has changed since)