fix: k8s_setup.sh should use newer kubectl release URL#167
Merged
SuperQ merged 1 commit intocoredns:masterfrom Nov 8, 2025
Merged
fix: k8s_setup.sh should use newer kubectl release URL#167SuperQ merged 1 commit intocoredns:masterfrom
k8s_setup.sh should use newer kubectl release URL#167SuperQ merged 1 commit intocoredns:masterfrom
Conversation
- Use the newer release URL for `kubectl`. - Quote wrap variables with user supplied values. Signed-off-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
Contributor
Author
|
I'm not sure how my PR is causing the failures raised below 🤷♂️ EDIT: I see recent commits merged to Reference - Failure logs
|
SuperQ
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details from troubleshooting a CI failure: coredns/coredns#7659 (comment)
Changes:
kubectl.Reminder, there's a Nov 2024 PR which might have been helpful in troubleshooting the cause more clearly: #161(UPDATE: Prefer improvement from #168)