Skip to content

fix: k8s_setup.sh should use newer kubectl release URL#167

Merged
SuperQ merged 1 commit intocoredns:masterfrom
polarathene:patch-1
Nov 8, 2025
Merged

fix: k8s_setup.sh should use newer kubectl release URL#167
SuperQ merged 1 commit intocoredns:masterfrom
polarathene:patch-1

Conversation

@polarathene
Copy link
Contributor

@polarathene polarathene commented Nov 7, 2025

Details from troubleshooting a CI failure: coredns/coredns#7659 (comment)

Changes:

  • Use the newer release URL for kubectl.
  • Quote wrap variables with user supplied values.

Reminder, there's a Nov 2024 PR which might have been helpful in troubleshooting the cause more clearly: #161 (UPDATE: Prefer improvement from #168)

- Use the newer release URL for `kubectl`.
- Quote wrap variables with user supplied values.

Signed-off-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
@polarathene
Copy link
Contributor Author

I'm not sure how my PR is causing the failures raised below 🤷‍♂️

EDIT: I see recent commits merged to master have CI failures, so they're just being ignored and this PR is not to blame.

Reference - Failure logs

external-plugin-tests

$ cd ~/go/src/${CIRCLE_PROJECT_USERNAME}/ci/test/kubernetai
$ go mod tidy
$ GO111MODULE=on go test -v ./...

# ...

# [github.com/coredns/ci/test/kubernetai]
./autopath_test.go:129:12: non-constant format string in call to (*testing.common).Fatalf
FAIL    github.com/coredns/ci/test/kubernetai [build failed]
FAIL

err = kubernetes.WaitForClientPodRecord(namespace)
if err != nil {
t.Fatalf(err.Error())
}


k8s-deployment-tests

$ mkdir -p ~/go/src/${CIRCLE_PROJECT_USERNAME}/deployment
$ git clone https://github.com/${CIRCLE_PROJECT_USERNAME}/deployment ~/go/src/${CIRCLE_PROJECT_USERNAME}/deployment
$ mkdir -p ~/go/src/${CIRCLE_PROJECT_USERNAME}/coredns
$ git clone https://github.com/${CIRCLE_PROJECT_USERNAME}/coredns ~/go/src/${CIRCLE_PROJECT_USERNAME}/coredns
$ cd ~/go/src/${CIRCLE_PROJECT_USERNAME}/ci/test/k8sdeployment
$ go mod tidy
$ GO111MODULE=on go test -v ./...

# ...

# [github.com/coredns/ci/test/k8sdeployment]
./configmap_test.go:76:12: non-constant format string in call to (*testing.common).Fatalf
FAIL    github.com/coredns/ci/test/k8sdeployment [build failed]
FAIL

if strings.Compare(corefileTranslated, corefileExpected) != 0 {
t.Fatalf("failed test: Translation does not match.\nGOT:\n" + corefileTranslated + "\n\nEXPECTED:\n" + corefileExpected)
}

@SuperQ SuperQ merged commit efbef7b into coredns:master Nov 8, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants