fix: wrong workspace sname in package.json commands#358
Open
vietanhrs wants to merge 1 commit intoOpenZeppelin:mainfrom
Open
fix: wrong workspace sname in package.json commands#358vietanhrs wants to merge 1 commit intoOpenZeppelin:mainfrom
vietanhrs wants to merge 1 commit intoOpenZeppelin:mainfrom
Conversation
WalkthroughTwo script commands in package.json were updated to reference Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyFixes #???
Problem: Cannot run yarn compact in the repository
Root cause: The package name for
contractsis different from the specified workspace name in the compact command of the root package.jsonFix: Rename the package
Test:

PR Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.