Skip to content

fix: wrong workspace sname in package.json commands#358

Open
vietanhrs wants to merge 1 commit intoOpenZeppelin:mainfrom
vietanhrs:tasks/fix-package
Open

fix: wrong workspace sname in package.json commands#358
vietanhrs wants to merge 1 commit intoOpenZeppelin:mainfrom
vietanhrs:tasks/fix-package

Conversation

@vietanhrs
Copy link

@vietanhrs vietanhrs commented Jan 22, 2026

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Fixes #???

Problem: Cannot run yarn compact in the repository

➜  compact-contracts git:(main) SKIP_ZK=true yarn compact
turbo 2.6.3

  × No package found with name '@openzeppelin-compact/contracts' in workspace

Root cause: The package name for contracts is different from the specified workspace name in the compact command of the root package.json

  • Expect: openzeppelin/compact-contracts
  • Actual: @openzeppelin-compact/contracts

Fix: Rename the package

Test:
image

PR Checklist

Summary by CodeRabbit

  • Chores
    • Updated build and test script configurations to reference revised package paths.

✏️ Tip: You can customize this high-level summary in your review settings.

@vietanhrs vietanhrs requested review from a team as code owners January 22, 2026 07:37
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Walkthrough

Two script commands in package.json were updated to reference @openzeppelin/compact-contracts instead of @openzeppelin-compact/contracts for the compact and test turbo run filters.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Updated scripts.compact and scripts.test filter paths from @openzeppelin-compact/contracts to @openzeppelin/compact-contracts (2 lines changed)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Update contracts package name #309 — Updates package references from @openzeppelin-compact/contracts to @openzeppelin/compact-contracts across the codebase to align with the new package namespace.

Suggested reviewers

  • andrew-fleming
  • 0xisk

Poem

🐰 A rabbit hops through paths so clean,
Renaming scripts to what they mean!
From -compact to just compact we flow,
Package names dancing in turbo's glow. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing an incorrect workspace name in package.json commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant