fix: wrong workspace name in package.json commands#354
fix: wrong workspace name in package.json commands#354vietanhrs wants to merge 3 commits intoOpenZeppelin:mainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis change updates npm script filter targets in package.json, renaming the package from Changes
Possibly related PRs
Suggested reviewers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
andrew-fleming
left a comment
There was a problem hiding this comment.
Thanks, @vietanhrs!
andrew-fleming
left a comment
There was a problem hiding this comment.
@vietanhrs Do you mind updating the commit with a verified sig?
80553b0 to
504e435
Compare
24e1e4e to
8cc6c73
Compare
8cc6c73 to
aa30272
Compare
@andrew-fleming I have created a new PR with a verified commit here: #358 I will close this old Pull Request Thanks a lot for your time |
Types of changes
What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an
xin the boxes that applyFixes #???
Problem: Cannot run yarn compact in the repository
Root cause: The package name for
contractsis different from the specified workspace name in the compact command of the root package.jsonFix: Rename the package
Test:

PR Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.