Skip to content

fix: wrong workspace name in package.json commands#354

Closed
vietanhrs wants to merge 3 commits intoOpenZeppelin:mainfrom
Nocturne-Labs:tasks/fix-package
Closed

fix: wrong workspace name in package.json commands#354
vietanhrs wants to merge 3 commits intoOpenZeppelin:mainfrom
Nocturne-Labs:tasks/fix-package

Conversation

@vietanhrs
Copy link

@vietanhrs vietanhrs commented Jan 16, 2026

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Fixes #???

Problem: Cannot run yarn compact in the repository

➜  compact-contracts git:(main) SKIP_ZK=true yarn compact
turbo 2.6.3

  × No package found with name '@openzeppelin-compact/contracts' in workspace

Root cause: The package name for contracts is different from the specified workspace name in the compact command of the root package.json

  • Expect: openzeppelin/compact-contracts
  • Actual: @openzeppelin-compact/contracts

Fix: Rename the package

Test:
image

PR Checklist

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Summary by CodeRabbit

  • Chores
    • Updated build and test script configurations for improved package reference organization.

✏️ Tip: You can customize this high-level summary in your review settings.

@vietanhrs vietanhrs requested review from a team as code owners January 16, 2026 06:16
@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This change updates npm script filter targets in package.json, renaming the package from @openzeppelin-compact/contracts to @openzeppelin/compact-contracts in two turbo-based scripts: compact and test. No behavioral changes occur; only the filter parameter is modified.

Changes

Cohort / File(s) Summary
npm script filter updates
package.json
Updated turbo filter targets in scripts.compact and scripts.test from @openzeppelin-compact/contracts to @openzeppelin/compact-contracts

Possibly related PRs

Suggested reviewers

  • andrew-fleming
  • 0xisk

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A package renamed, filters aligned with care,
From @openzeppelin-compact to compact-contracts fair,
Two scripts now point to the path that's true,
Clean and precise—the turbo build shines through! 🎯

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'fix: wrong workspace name in package.json commands' accurately describes the main change: correcting incorrect workspace names in npm scripts from '@openzeppelin-compact/contracts' to '@openzeppelin/compact-contracts'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vietanhrs!

Copy link
Contributor

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vietanhrs Do you mind updating the commit with a verified sig?

@vietanhrs vietanhrs force-pushed the tasks/fix-package branch 2 times, most recently from 80553b0 to 504e435 Compare January 22, 2026 07:12
@vietanhrs
Copy link
Author

@vietanhrs Do you mind updating the commit with a verified sig?

@andrew-fleming I have created a new PR with a verified commit here: #358

I will close this old Pull Request

Thanks a lot for your time

@vietanhrs vietanhrs closed this Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants