Skip to content

Cleanup codebase and update to 26.1#1256

Draft
misode wants to merge 45 commits intomasterfrom
update-26.1
Draft

Cleanup codebase and update to 26.1#1256
misode wants to merge 45 commits intomasterfrom
update-26.1

Conversation

@misode
Copy link
Member

@misode misode commented Jan 26, 2026

🫡😢 Discontinued modules

We decided to discontinue some modules with this update. This is necessary to keep the project maintainable and allows us to add new modules without growing endlessly. They are listed here along with some of our reasoning:

  • Better Fire
  • Enchantment Extractors
    • It is able to separate good enchantments and curses
    • Doesn't work for custom enchantments
  • Enderman Support Class
  • Forming Press
    • A worse crafting table (not much initial cost) that gives access to more efficient recipes
  • Heart Canisters
    • This is a boring implementation of extra hearts
  • Mob Curing
    • Feels random
  • Mountaineering
    • Very niche use case, not intuitive to use
  • Poses Pack
    • Hardcoded poses aren't necessary now that poses can be fully customized
  • Potion Swords
    • Mainly used to get wither skulls, which is OP. The rest of the module is unused
  • Relocators
    • Not really used except for liquid tanks
  • XP Storage
    • Does the same as liquid tanks but with no cost
  • Custom Crafters (library)
    • Almost fully replaced by vanilla recipes (see feature changes for exceptions)
  • Trades (library)
    • Modules can now use the villager_trade JSON files to add content

✨ Feature changes

  • With the removal of custom crafters, you can no longer craft boots of ostara from existing leather boots. Removed Flippers of Ostara.
  • Apple trees now only have a 7% chance of appearing in a wandering trader, instead of always being guaranteed

🐛 Fixes

  • Crafted orbs of ankou did not have all the intended properties (max stack to 1, fire resistant, equippable in offhand)
  • The item name of "Potion of Floating" was most likely not working correctly

🚧 TODO

  • Remove overlays
  • Discontinue modules
  • Replace guidebook gm4_recipes with vanilla recipes
  • Update standard crafting video containing custom crafter
  • Change custom_name components into item_name (not sure if we should do this?)
  • Change custom model data to use strings (partially using script)
  • Remove beet.contrib.model_merging
  • Update the docs
  • Update to 26.1 snapshots
  • Update biome-extensions
  • Use villager_trade JSON files for wandering trader customization
  • Replace some technical loot tables with macro functions
  • Rethink how Everstones should work now
  • Use timelines, env attributes and a separate world clock for mysterious midnights
  • User atlas text components for recipes in guidebook
  • Remove the modeldata registry
  • Bump minor versions of all modules
  • Remember to create a new 26.1/meta.json file in the release branch, or modify the script to handle this
  • Finish this to-do list

Notes

  • Teleportation anchors uses unknown objective gm4_et_data
  • Liquid tanks deposit_one_level and withdraw_one_level have a syntax error with playsound command

@Bloo-dev Bloo-dev added quality-update Improves efficiency or structure without affecting functionality of a module and removed quality-update Improves efficiency or structure without affecting functionality of a module labels Jan 27, 2026
Not possible in the following cases:
- Any machine block or cart, because custom name is used for place and destroy detection
- SCUBA items, to avoid conflicts with the open PR
- Items with components that override the item_name, for example potion_contents
BPR02 and others added 10 commits February 28, 2026 09:57
* delete `#gm4:air`

* Update `#gm4:replaceable`
MC-261616 prevents us from replacing this with the vanilla tag completely

* Deprecate `#gm4:boats` for `#minecraft:boat`

* Remove teleportation_anchors `vehicles` tag as it was unused

* Update teleportation anchors `in_vehicle` predicate to not need to check vehicle type. Tested in game, works as expected.

* Change `#gm4:undead` to `#minecraft:undead` for metallurgy and OoA

* Update `#gm4_tunnel_bores:not_rail_solid` to use `#minecraft:chains`

* Update `#gm4_tunnel_bores:rail_replaceable` to use `#gm4:replaceable`

* Remove required false from all entity type, block, and item tags
)

* Replace team hack for selecting mobs with `type=!#gm4:non_living`

* remaining instances that i missed
* Missing advancements

* Enable recipe grouping with vanilla recipes

* Honeycomb recipe

* Dispenser recipe

* Bone Block recipe

* Chest recipe with logs

* Paper recipe in bulk

* Pink Petals recipe

* Cherry Leaves recipe

* Chain recipe in bulk

* Brown Dye recipe

* Green Dye recipe

* Bump Version & add myself to credits

* Rename red sand from red sandstone recipe

* Update red sand conversion recipe to use iron_nugget

* Revert "Paper recipe in bulk"

This reverts commit 7b09d6d.
* fix guidebook item resolver

- supports non-vanilla tags
- supports {"id": "...", "required": false} entries in item tags (previously assumed strings)

* fix function call

* fix the other function call

* support non-namespaced tags

* revert standard crafting change

(used for testing)

* remove duplicate logic

* avoid redundant string mutation

* prevent infinite loop for item tag cycle

* set maxsplit when splitting item tag

Co-authored-by: Bloo <git@bloo.boo>

---------

Co-authored-by: Bloo <git@bloo.boo>
* Update donor damage to use `/damage`

* Remove recipient non-sneaking requirement

* Little bit of recipient logic refactoring

* Update function headers

* Update predicate to support offhand

* Update guidebook to reflect wither roses do actually work

* fix: 2 players being valid donors

* Rename attributes

* change damage to magic

* change predicate to use slots

* remove any of
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants