Teleportation Anchors: replace display armor stand with item display#1269
Open
runcows wants to merge 6 commits intoGamemode4Dev:update-26.1from
Open
Teleportation Anchors: replace display armor stand with item display#1269runcows wants to merge 6 commits intoGamemode4Dev:update-26.1from
runcows wants to merge 6 commits intoGamemode4Dev:update-26.1from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Bloo-dev
added
the
quality-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces display armor stand with item display for Teleportation Anchors and Jammers.
Item displays are located at the center of the blocks, same place as the markers.
Aside from modernizing, this also fixes an issue with the resource pack that cropped up last version, where the small armor stand heads started rendering bigger. This meant that the places we used this had their models inflated a bit and no longer fit the block. This issue affects other modules too, just addressing this per module.
Due to the needed upgrade path, the minor version has been bumped. This is of note for #1256 where we want to bump all minor versions anyway.I have tested the item display in game and it works as expected. I have not yet tested the upgrade path, but after combing over it for a while, I see no reason it shouldn't work. Will test soon though.