Fix lints from Herb #107
Merged
Fix lints from Herb #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@joelhawksley thanks for the PR, looks good to me. I think there is one test case that I should make explicit now, which is the self-closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes linting errors surfaced by https://github.com/marcoroth/herb.
However, there are some remaining errors around requiring alt/title attributes that I did not fix, as I believe that those should not break the parser.
There is also a remaining error for internal anchor tags that I believe is incorrect. I've filed a parser bug report here: marcoroth/herb#1065
cc @marcoroth