Skip to content

Conversation

@ejohnstown
Copy link
Contributor

@ejohnstown ejohnstown commented Jan 5, 2026

Found with scan-build.

  1. When looking up a name in the name-ID map, don't bother checking if the name is NULL.
  2. The GetString functions should fail if the destination string parameter is NULL.
  3. The GetString functions should not bother to copy an empty string found in the data stream.
  4. When checking the public key type provided by the callback, do not check it when it is NULL.

@ejohnstown ejohnstown changed the title Fix String References Release v1.4.22 Jan 5, 2026
JacobBarthelmeh
JacobBarthelmeh previously approved these changes Jan 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This release addresses NULL pointer and boundary check issues identified by the scan-build static analysis tool, improving code robustness and preventing potential crashes.

  • Added NULL pointer checks before memory operations and string comparisons
  • Modified string handling functions to avoid unnecessary operations on empty strings
  • Refactored error handling to use consistent control flow patterns with cascading checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

1. When looking up a name in the name-ID map, don't bother checking if
   the name is NULL.
2. The GetString functions should fail if the destination string
   parameter is NULL.
3. The GetString functions should not bother to copy an empty string
   found in the data stream.
4. When checking the public key type provided by the callback, do not
   check it when it is NULL.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JacobBarthelmeh JacobBarthelmeh merged commit 7d48298 into wolfSSL:master Jan 6, 2026
99 checks passed
@ejohnstown ejohnstown deleted the release-1.4.22-2 branch January 6, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants