Fix String References #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ejohnstown
commented
Jan 5, 2026
ejohnstown
commented
- Fix memory leak in the GetStringAlloc() function.
- Remove some redundant code when processing a pty-request.
JacobBarthelmeh
previously approved these changes
Jan 5, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses memory management issues in the GetStringAlloc() function and refactors the pty-request handling code to eliminate redundancy. The key changes include adding an optional size parameter to GetStringAlloc() and streamlining variable usage in the pty-request processing logic.
- Added a new
sSzparameter toGetStringAlloc()to optionally return the allocated string size - Refactored pty-request handling to directly assign parsed values to ssh object fields instead of using temporary variables
- Updated the ChangeLog version date
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wolfssh/internal.h | Updated GetStringAlloc function signature to include optional sSz parameter |
| src/internal.c | Implemented the new parameter in GetStringAlloc, updated all call sites with NULL for the new parameter where size is not needed, and refactored pty-request handling to eliminate redundant temporary variables |
| ChangeLog.md | Updated release date from December 31, 2025 to January 5, 2026 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1. Modify GetStringAlloc() to also take the string length as provided by GetUint32(). 2. New use of GetStringAlloc() was misusing the heap. Fix using the updated GetStringAlloc() function. 3. For a pty-req, directly update the heights, widths, and mode.
1. Update ChangeLog for release date.
JacobBarthelmeh
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.