Fix latest rust build, 1688+ support #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Collaborator
|
should prolly draft if it shouldn't be merged |
|
Will this fix the debugger? Cause it's broken above versions 1666 |
Contributor
Author
Yes it fixes the debugger |
Contributor
We're aware. |
|
Thank you for the quick response I thought this PR was forgotten after a month of inactivity |
* cargo fmt * versioned unions * Revert "cargo fmt" This reverts commit 688c54e. * change to use accessors --------- Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Contributor
Author
|
thanks @hry-gh for the work on fixing the versioning. this is ready to merge now, no longer a draft |
Absolucy
approved these changes
Jan 27, 2026
Collaborator
Absolucy
left a comment
Absolucy
left a comment
There was a problem hiding this comment.
linux ci failure is unrelated to this PR, so, I'll merge this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps the detour library to retour, which is just an updated fork of the ancient detour library which finally broke on latest stable Rust.
Updates the ExecutionContext to latest 516 structure.
Updates dmasm to latest, which adds 516 instructions.
Adds several missing value types, borrowed from Meowtonin. (Thanks @ZeWaka, #101)
Do not merge. ExecutionContext needs refactoring to be made into a versioned union, similar to other types, otherwise older version compat will blow up immediately.