Bugfix: avoid squeezing batch size 1 dimension in lstm and gru emulation code #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes an issue of squeeze and unsqueeze emulation code. It should use for...of loop to get axes values rather than indices. Fix webmachinelearning#889
reillyeon
approved these changes
Jan 5, 2026
fdwr
approved these changes
Jan 7, 2026
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
It should use for...of loop to get axes values rather than indices.
Oh Javascript, you're so special there compared to every other programming language... 🤦♂️ Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an issue of squeeze and unsqueeze emulation code. It should use
for...ofloop to get axes values rather than indices.Fix #889
Preview | Diff