fix(task): use dialed number (dn) instead of ANI for outdial task titles#633
Draft
bhabalan wants to merge 1 commit intowebex:nextfrom
Draft
fix(task): use dialed number (dn) instead of ANI for outdial task titles#633bhabalan wants to merge 1 commit intowebex:nextfrom
bhabalan wants to merge 1 commit intowebex:nextfrom
Conversation
IncomingTask and TaskList widgets displayed the entrypoint/ANI number instead of the dialed destination number for outdial calls. This aligns them with CallControlCAD which was already fixed in ce826f2. CAI-7359
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES
https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7359
This pull request addresses
When making an outdial call via dialpad, the IncomingTask, TaskList, and active task widgets display the entrypoint/ANI number instead of the dialed destination number. CallControlCAD was already fixed in #629 (ce826f2) but IncomingTask and TaskList were missed.
by making the following changes
Extract
dn(dialed number) fromcallAssociatedDetailsand usedn || anifor the telephony title in IncomingTask and TaskList, matching the pattern already used in CallControlCAD.incoming-task.utils.tsx— extractdn, usedn || anifor title, adddntoIncomingTaskDatainterfacetask-list.utils.ts— extractdn, usedn || anifor titletask.types.ts— adddntoTaskListItemDatainterfacednpriority andanifallbackChange Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.