Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@
"clean": "yarn workspaces foreach --all --topological --parallel run clean && rm -rf node_modules",
"clean:dist": "yarn workspaces foreach --all --topological --parallel run clean:dist",
"test:unit": "yarn run test:tooling && yarn run test:cc-widgets",
"test:e2e:cc": "TEST_SCOPE=cc yarn playwright test",
"test:e2e:meetings": "TEST_SCOPE=meetings yarn playwright test",
"test:e2e": "yarn playwright test",
"test:styles": "yarn workspaces foreach --all --exclude webex-widgets run test:styles",
"test:tooling": "jest --coverage",
Expand All @@ -69,4 +71,4 @@
"prepare": "husky",
"package-tools": "webex-package-tools"
}
}
}
11 changes: 2 additions & 9 deletions packages/@webex/widgets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"release:debug": "semantic-release --debug",
"release:dry-run": "semantic-release --dry-run",
"start": "npm run demo:serve",
"test:e2e": "npm run demo:build && wdio wdio.conf.js",
"test:e2e": "npm run demo:build && cd ../../.. && yarn run test:e2e:meetings",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install Playwright deps before running meetings E2E

This script now runs the meetings suite through Playwright, but the e2e_test_meetings workflow path (.github/workflows/pull-request.yml, step Test E2E at line 193) invokes it without the npx playwright install --with-deps step that the CC Playwright job uses at lines 220-221. On fresh GitHub runners (empty Playwright browser cache), the setup project will fail before tests because required browser binaries/system deps are missing, so this change breaks the meetings E2E pipeline unless that install step is added.

Useful? React with 👍 / 👎.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, will raise separate PR for this.

"test:eslint": "echo 'Broken eslint tests'",
"test:eslint:broken": "eslint src/"
},
Expand Down Expand Up @@ -55,16 +55,9 @@
"@commitlint/cli": "^8.3.5",
"@commitlint/config-conventional": "^8.3.4",
"@momentum-ui/react": "^23.21.4",
"@playwright/test": "1.51.1",
"@semantic-release/changelog": "^6.0.0",
"@semantic-release/git": "^10.0.0",
"@wdio/cli": "^7.3.1",
"@wdio/jasmine-framework": "^7.4.6",
"@wdio/junit-reporter": "^7.4.2",
"@wdio/local-runner": "^7.4.6",
"@wdio/selenium-standalone-service": "^7.5.2",
"@wdio/spec-reporter": "^7.4.3",
"@wdio/static-server-service": "^7.5.7",
"@webex/test-users": "^1.157.0",
"babel-eslint": "^10.0.3",
"babel-loader": "^8.0.6",
"babel-plugin-transform-object-rest-spread": "^6.26.0",
Expand Down
158 changes: 0 additions & 158 deletions packages/@webex/widgets/tests/WebexMeeting.e2e.js

This file was deleted.

29 changes: 0 additions & 29 deletions packages/@webex/widgets/tests/pages/MeetingWidget.page.js

This file was deleted.

23 changes: 0 additions & 23 deletions packages/@webex/widgets/tests/pages/Samples.page.js

This file was deleted.

54 changes: 0 additions & 54 deletions packages/@webex/widgets/tests/util.js

This file was deleted.

Loading
Loading