fix: collect all mouse movement data#664
fix: collect all mouse movement data#664AndreVto wants to merge 1 commit intoutkarshdalal:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/java/com/winlator/widget/TouchpadView.java">
<violation number="1" location="app/src/main/java/com/winlator/widget/TouchpadView.java:714">
P1: User sensitivity and cursor acceleration logic was mistakenly removed from captured pointer movement</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| dy += event.getHistoricalY(i); | ||
| } | ||
|
|
||
| dx += event.getX(); |
There was a problem hiding this comment.
P1: User sensitivity and cursor acceleration logic was mistakenly removed from captured pointer movement
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At app/src/main/java/com/winlator/widget/TouchpadView.java, line 714:
<comment>User sensitivity and cursor acceleration logic was mistakenly removed from captured pointer movement</comment>
<file context>
@@ -701,19 +701,22 @@ public float[] computeDeltaPoint(float lastX, float lastY, float x, float y) {
+ dy += event.getHistoricalY(i);
}
+
+ dx += event.getX();
+ dy += event.getY();
this.xServer.injectPointerMoveDelta(Mathf.roundPoint(dx), Mathf.roundPoint(dy));
</file context>
There was a problem hiding this comment.
custom sensitivity is not actually used in the app and always returns 1, the acceleration logic was probably trying to fix this exact same issue but failing to cover all cases
1 participant
Collect all mouse movement instead of just the last delta
This is a fix required for wireless USB mouse to work correctly inside the container
Summary by cubic
Collects all mouse movement during ACTION_MOVE (history + current) to prevent lost deltas. Fixes choppy or unresponsive movement for wireless USB mice inside the container.
Written for commit 4c82ecc. Summary will update on new commits.
Summary by CodeRabbit