Skip to content

Fix ErrorResponse.toJSON examples #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KyleJune merged 2 commits into from
Apr 7, 2025
Merged

Fix ErrorResponse.toJSON examples #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87602e7
Fix ErrorResponse.toJSON examples
KyleJune Apr 7, 2025
993a253
Remove deprecated bundle step from github action
KyleJune Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,10 @@ jobs:
shell: bash
run: |
echo "RELEASE_VERSION=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV
- name: Bundle
if: env.RELEASE_VERSION != ''
run: |
mkdir -p target/release
deno bundle mod.ts target/release/http-error.${RELEASE_VERSION}.js
- name: Release
uses: softprops/action-gh-release@v1
if: env.RELEASE_VERSION != ''
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
draft: true
files: |
target/release/http-error.${{ env.RELEASE_VERSION }}.js
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ import { ErrorResponse, HttpError, isErrorResponse } from "@udibo/http-error";

async function getMovies() {
const response = await fetch("https://example.com/movies.json");
if (!response.ok) throw new ErrorResponse.toError(movies);
if (!response.ok) throw await ErrorResponse.toError(response);
return await response.json();
}
```
Expand All @@ -213,7 +213,7 @@ import { ErrorResponse, HttpError, isErrorResponse } from "@udibo/http-error";
async function getMovies() {
const response = await fetch("https://example.com/movies.json");
const movies = await response.json();
if (isErrorResponse(movies)) throw new ErrorResponse.toError(movies);
if (isErrorResponse(movies)) throw ErrorResponse.toError(movies);
if (response.status >= 400) {
throw new HttpError(response.status, "Invalid response");
}
Expand Down
2 changes: 1 addition & 1 deletion deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@udibo/http-error",
"version": "0.9.0",
"version": "0.9.1",
"exports": {
".": "./mod.ts"
},
Expand Down
4 changes: 2 additions & 2 deletions mod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ export class ErrorResponse<
*
* async function getMovies() {
* const response = await fetch("https://example.com/movies.json");
* if (!response.ok) throw new ErrorResponse.toError(response);
* if (!response.ok) throw await ErrorResponse.toError(response);
* return await response.json();
* }
* ```
Expand All @@ -482,7 +482,7 @@ export class ErrorResponse<
* async function getMovies() {
* const response = await fetch("https://example.com/movies.json");
* const movies = await response.json();
* if (isErrorResponse(movies)) throw new ErrorResponse.toError(movies);
* if (isErrorResponse(movies)) throw ErrorResponse.toError(movies);
* if (response.status >= 400) {
* throw new HttpError(response.status, "Invalid response");
* }
Expand Down