Conversation
Author
|
all conflicts already resolved |
13rac1
suggested changes
Nov 25, 2019
Contributor
13rac1
left a comment
13rac1
left a comment
There was a problem hiding this comment.
Thanks for your contribution! It'll be great to get this running in Ubuntu 18.
What can we do to reduce the scope of this PR? There are a number of changes beyond updating to Ubuntu 18, plus a few which seem incorrect. I prefer to merge a bare minimum change set. Please update this branch to remove all unnecessary changes, then document reasoning for the required changes in the git commit message body.
| "variables": { | ||
| "PACKER_OS_FLAVOUR": "ubuntu", | ||
| "PACKER_BOX_NAME": "ubuntu-14.04.6-server-amd64", | ||
| [ |
| ] | ||
| ] | ||
| } | ||
| } No newline at end of file |
| "droplet_name": "udacity-devops", | ||
| "private_networking": true | ||
| } | ||
| "type": "digitalocean", |
Contributor
There was a problem hiding this comment.
Extra spaces, this needs to be run through a formatter to make it consistent.
| @@ -1,5 +1,3 @@ | |||
| #!/bin/bash -eux | |||
Contributor
There was a problem hiding this comment.
Please don't remove the hashbang
| "scripts": [ | ||
| "scripts/jenkins.sh", | ||
| "scripts/graphite.sh", | ||
| "scripts/nginx.sh", |
Contributor
There was a problem hiding this comment.
Why are jenkins, graphite and nginx removed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
i made some changes on JSON's files, that's was possible run a VM with ubuntu 18 in my computer. I think cool and just wanna share.