Skip to content

PD-2525 Move Privileges to Stand-alone article#4459

Merged
tonyriv3 merged 11 commits intomasterfrom
PD-2525-Create-PrivilegesScreens.md-Article
Mar 13, 2026
Merged

PD-2525 Move Privileges to Stand-alone article#4459
tonyriv3 merged 11 commits intomasterfrom
PD-2525-Create-PrivilegesScreens.md-Article

Conversation

@micjohnson777
Copy link
Contributor

This PR moves the Privileges screens content out of the LocalGroupsScreens.md article into a stand-alone article.

Does not backport to 25.10.

Thanks for contributing to TrueNAS documentation! By opening a Pull Request, you're acknowledging that your changes will be distributed under the Creative Commons 4.0 license.

This PR moves the Privileges screens content out of the LocalGroupsScreens.md article into a stand-alone article.
@micjohnson777 micjohnson777 requested a review from a team as a code owner March 5, 2026 18:40
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 5 issues found in changed files - 1 errors, 0 warnings, 4 suggestions

Changed files with issues:

content/SCALE/Credentials/PrivilegesScreens.md (5 issues)

  • Lines 45, 46 - suggestion: Use active voice instead of passive voice
  • Line 45 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

@DjP-iX DjP-iX added the Technical Writer Review (DP) A technical writer is reviewing the PR. label Mar 10, 2026
@github-actions
Copy link

github-actions bot commented Mar 10, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 5 issues found in changed files - 1 errors, 0 warnings, 4 suggestions

Changed files with issues:

content/SCALE/Credentials/PrivilegesScreens.md (5 issues)

  • Lines 45, 46 - suggestion: Use active voice instead of passive voice
  • Line 45 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

DjP-iX
DjP-iX previously requested changes Mar 10, 2026
Copy link
Contributor

@DjP-iX DjP-iX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micjohnson777 in addition to the minor review edit suggestions I think this PR is incomplete as is.

It's missing an edit to Credentials\Groups\LocalGroupsScreens.md needed to remove the old Privileges screen content.

There is also Managing Privileges tutorial content that needs to be removed from Credentials\Groups\ManageLocalGroups.md and moved to a standalone article. To be consistent with the other areas like in /Groups currently, you'll also need to create a /Privileges directory and landing page (look at examples in other directories), so the final file structure should look like:

Credentials/Privileges/
├── _index.md         (landing page)
├── Privileges.md     (tutorial)
└── PrivilegesScreens.md  (reference)

micjohnson777 and others added 3 commits March 12, 2026 08:03
Co-authored-by: Dan Pizappi <133042991+DjP-iX@users.noreply.github.com>
Co-authored-by: Dan Pizappi <133042991+DjP-iX@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 5 issues found in changed files - 1 errors, 0 warnings, 4 suggestions

Changed files with issues:

content/SCALE/Credentials/PrivilegesScreens.md (5 issues)

  • Lines 45, 46 - suggestion: Use active voice instead of passive voice
  • Line 45 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 5 issues found in changed files - 1 errors, 0 warnings, 4 suggestions

Changed files with issues:

content/SCALE/Credentials/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

1 similar comment
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 5 issues found in changed files - 1 errors, 0 warnings, 4 suggestions

Changed files with issues:

content/SCALE/Credentials/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

Co-authored-by: Dan Pizappi <133042991+DjP-iX@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 5 issues found in changed files - 1 errors, 0 warnings, 4 suggestions

Changed files with issues:

content/SCALE/Credentials/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

This commit adds the Privileges section to the Credential navigation structure and creates the tutorials by moving privileges content out of the ManagingLocalGroups.md tutorial.
It also removes the privileges content from the LocalGroupsScreens.md article
This commit deletes the privileges content in the ManageLocalGroups.md tutorial.
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 23 issues found in changed files - 2 errors, 0 warnings, 21 suggestions

Changed files with issues:

content/SCALE/Credentials/Groups/LocalGroupsScreens.md (10 issues)

  • Lines 17, 23, 48 - suggestion: Use active voice instead of passive voice
  • Line 21 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 39 - suggestion: Spell out 'GID' on first use

content/SCALE/Credentials/Groups/ManageLocalGroups.md (7 issues)

  • Lines 38, 39, 50 - suggestion: Spell out 'GID' on first use
  • Line 42 - suggestion: Keep sentences under 30 words
  • Line 50 - suggestion: Use active voice instead of passive voice

content/SCALE/Credentials/Privileges/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

content/SCALE/Credentials/Privileges/ManagePrivileges.md (1 issues)

  • Line 26 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

@micjohnson777
Copy link
Contributor Author

Good catch @DjP-iX! I should not rush with "quick" fixes.

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 16 issues found in changed files - 2 errors, 0 warnings, 14 suggestions

Changed files with issues:

content/SCALE/Credentials/Groups/LocalGroupsScreens.md (10 issues)

  • Lines 17, 23, 48 - suggestion: Use active voice instead of passive voice
  • Line 21 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 39 - suggestion: Spell out 'GID' on first use

content/SCALE/Credentials/Privileges/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

content/SCALE/Credentials/Privileges/ManagePrivileges.md (1 issues)

  • Line 26 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

@DjP-iX DjP-iX removed the Technical Writer Review (DP) A technical writer is reviewing the PR. label Mar 12, 2026
@github-actions
Copy link

github-actions bot commented Mar 13, 2026

Vale Style Guide Issues (Previous - Click to expand)

Vale Style Guide Issues

📊 Summary: 23 issues found in changed files - 2 errors, 0 warnings, 21 suggestions

Changed files with issues:

content/SCALE/Credentials/Groups/LocalGroupsScreens.md (10 issues)

  • Lines 17, 23, 48 - suggestion: Use active voice instead of passive voice
  • Line 21 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 39 - suggestion: Spell out 'GID' on first use

content/SCALE/Credentials/Groups/ManageLocalGroups.md (7 issues)

  • Lines 38, 39, 50 - suggestion: Spell out 'GID' on first use
  • Line 42 - suggestion: Keep sentences under 30 words
  • Line 50 - suggestion: Use active voice instead of passive voice

content/SCALE/Credentials/Privileges/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

content/SCALE/Credentials/Privileges/ManagePrivileges.md (1 issues)

  • Line 26 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

@DjP-iX DjP-iX dismissed their stale review March 13, 2026 16:51

stale

@github-actions
Copy link

Vale Style Guide Issues

📊 Summary: 23 issues found in changed files - 2 errors, 0 warnings, 21 suggestions

Changed files with issues:

content/SCALE/Credentials/Groups/LocalGroupsScreens.md (10 issues)

  • Lines 17, 23, 48 - suggestion: Use active voice instead of passive voice
  • Line 21 - suggestion: Don't use language (such as 'disabled') that defines people by their disability.
  • Line 39 - suggestion: Spell out 'GID' on first use

content/SCALE/Credentials/Groups/ManageLocalGroups.md (7 issues)

  • Lines 38, 39, 50 - suggestion: Spell out 'GID' on first use
  • Line 42 - suggestion: Keep sentences under 30 words
  • Line 50 - suggestion: Use active voice instead of passive voice

content/SCALE/Credentials/Privileges/PrivilegesScreens.md (5 issues)

  • Lines 43, 44 - suggestion: Use active voice instead of passive voice
  • Line 43 - error: Don't add '(s)' to a singular noun. Use plural instead.

content/SCALE/Credentials/Privileges/ManagePrivileges.md (1 issues)

  • Line 26 - error: Don't add '(s)' to a singular noun. Use plural instead.

🔧 To fix: Review the issues above and update your documentation accordingly.

@tonyriv3 tonyriv3 merged commit dc23b7d into master Mar 13, 2026
5 checks passed
@tonyriv3 tonyriv3 deleted the PD-2525-Create-PrivilegesScreens.md-Article branch March 13, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants