Merged
Conversation
wellingtoncosta
approved these changes
Feb 24, 2026
We removed the companion overloads because they were causing an ambiguous overload error if you named the tag.
This will break existing uses which add the tag without a named parameter `Logger.i("tag") {"Message"}` because the version of the function on the parent class has the throwable parameter first.
To avoid this break, this change adds back in a version of the function with tag as a first parameter, but gives it a different parameter name to avoid ambiguity
samhill303
force-pushed
the
sh/compat-overload
branch
from
c3d6267 to
63f56b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed the companion overloads because they were causing an ambiguous overload error if you named the tag.
This will break existing uses which add the tag without a named parameter
Logger.i("tag") {"Message"}because the version of the function on the parent class has the throwable parameter first.To avoid this break, this change adds back in a version of the function with tag as a first parameter, but gives it a different parameter name to avoid ambiguity