Replace octicon element with a static unicode symbol#130
Open
N7K4 wants to merge 3 commits intotoshimaru:mainfrom
Open
Replace octicon element with a static unicode symbol#130N7K4 wants to merge 3 commits intotoshimaru:mainfrom
N7K4 wants to merge 3 commits intotoshimaru:mainfrom
Conversation
|
I've tried this out and it appears to work as expected. I've rebased atop the latest version of jekyll-toc in my own fork: https://github.com/potbanksoftware/jekyll-toc/commits/my0150/ There were only a few minor merge conflicts but it works on my site. |
|
Actually I did run into one issue. With a header like this: # Foo `bar`the chain symbol gets inserted between the plain text "Foo" and the code tag for "bar". I did 0283cad which appears to work but I do not know ruby and didn't write tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a octicon span element, this is now replaced by the configure able
anchor_symbolunicode link symbol🔗The symbol is placed behind the headline, the octicon span was placed before the headline
Fixes #24