Conversation
|
@tomaz, can you please review? Thanks! |
|
It's been many years since I last used a Mac, so have no experience with M chips. Instructions seem fine, however your branch is behind master, please rebase, then it can be merged. |
|
Thanks, @tomaz, for helping out. Much appreciated! I checked the logs and I think it's up to date. See logs below. That said, I might be mistaken. Please advise. Thanks! |
|
Indeed, looks like the right history for However I just noticed commit message - could you change that into more explanatory sentence. Smth like "Added instructions for using on M1 Macs" or similar. Just "m1" doesn't tell what the commit is about. After merging all this discussion is not visible on the repository itself, so all the context is gone. Hence I always strive to keep the messages relevant. Sorry but was puzzled to the misterious "rebase and merge" before and didn't pay attention. Afterwards I'll hit the button and then let's see what happens... |
Adds installation instructions for computers running on M1 silicon