feat(os): add UserConfigDir and UserCacheDir#5044
Open
mikesmitty wants to merge 1 commit intotinygo-org:devfrom
Open
feat(os): add UserConfigDir and UserCacheDir#5044mikesmitty wants to merge 1 commit intotinygo-org:devfrom
mikesmitty wants to merge 1 commit intotinygo-org:devfrom
Conversation
603ef72 to
a746e6f
Compare
Member
|
@mikesmitty looks like this needs to be behind a build tag since those functions do not exist in older Go versions. |
Member
|
internal/filepathlite was added in Go 1.23, so we can't rely on it. We could, however, have our own internal/filepathlite package instead. For that you'd need to modify the following code to add the package as well: Line 245 in 3869f76 (Add "internal/filepathlite": false,, and preferably also a note to the files like "This is needed for Go 1.22 compatibility").
|
Member
|
We'd have to import the entire |
Contributor
|
... or after 1.26 release we could drop 1.22 support 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5040