Support for controls clause, more options available out of 'extra_options'#69
Open
LAripping wants to merge 17 commits intothias:masterfrom
Open
Support for controls clause, more options available out of 'extra_options'#69LAripping wants to merge 17 commits intothias:masterfrom
LAripping wants to merge 17 commits intothias:masterfrom
Conversation
The template now includes clauses for these values, instead of forcing the edit of their values.
Currently it's a hardcoded option, not overwriteable used only to help us with our implementation. In a future commit this must be more dynamic enabling the addition of multiple (or none) inets, ability to skip completely the `controls ` clause and so on
...before pushing local (work PC) mods enabling custom `controls` in the template and more dynamic `dnssec`-related options.
Currently, the changes to be proposed for merging upstream in the base project (thias's module), relate to the configuration applied and they are: 1. DNSsec options are not mandatory, so their values are not printed in the conf file (via the template) if not modified 2. Location of the key-file is now parametric. Again, template adds it in the conf only if specific value is given. 3. Support for `controls` clause. Providing options regarding the rndc channel the user might use.
1. auth-nxdomain {yes | no}
2. notify {yes | no | explicit}
3. allow-notify { ;-separated list of IP addrs }
4. request-ixfr {yes | no}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly additions, PR does not break anything. In detail:
1.Support for
controlsclause. Conf. template providing options regarding the rndcchannel the user might use. (Also requested in #63)
2.Many common options can be specified without the use of
extra-options. Namely:*
allow-new-zones(yes | no)*
allow-notify(IP adr. list)*
notify(yes | no | explicit)*
auth-nxdomain(yes | no)*
request-ixfr(yes | no)3. DNSsec options are now not mandatory, so their values are not printed in
the conf file if they are not specified.
4. Location of the key-file is now parametric. Again, template adds it
in the configuration only if the path is explicitly specified.