Skip to content

Change checks in TimeZoneEquals to assertions #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
catamorphism wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change checks in TimeZoneEquals to assertions #3231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions polyfill/lib/ecmascript.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
IntlDateTimeFormatPrototypeGetFormat,
IntlDateTimeFormatPrototypeResolvedOptions,
IntlSupportedValuesOf,
JSONStringify,
MapPrototypeGet,
MapPrototypeHas,
MapPrototypeSet,
Expand Down Expand Up @@ -1812,9 +1813,9 @@ export function TimeZoneEquals(one, two) {
// can come from the argument of TimeZone.p.equals as opposed to the first
// ID which comes from the receiver.
const idRecord2 = GetAvailableNamedTimeZoneIdentifier(two);
if (!idRecord2) return false;
assert(idRecord2, `${JSONStringify(two)} has an invalid time zone`);
const idRecord1 = GetAvailableNamedTimeZoneIdentifier(one);
if (!idRecord1) return false;
assert(idRecord1, `${JSONStringify(one)} has an invalid time zone`);
return idRecord1.primaryIdentifier === idRecord2.primaryIdentifier;
} else {
return offsetMinutes1 === offsetMinutes2;
Expand Down