Draft
Conversation
grynspan
added
enhancement
grynspan
force-pushed
the
jgrynspan/encodedattachment-as-spi
branch
from
5deb8e8 to
fa0b33c
Compare
Follow-up to #1587. Exposes `ABI.EncodedAttachment` as SPI. A value of this type is associated with the `valueAttached` event kind. The type already conforms to `Attachable` so it can be directly plumbed back into Swift Testing, and XCTest internally knows how to convert an `Attachable` value to an `XCTAttachment`.
grynspan
force-pushed
the
jgrynspan/encodedattachment-as-spi
branch
from
fa0b33c to
e74d2bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1587.
Exposes
ABI.EncodedAttachmentas SPI. A value of this type is associated with thevalueAttachedevent kind. The type already conforms toAttachableso it can be directly plumbed back into Swift Testing, and XCTest internally knows how to convert anAttachablevalue to anXCTAttachment.Checklist: