fix: apply log_level from options payload during startup #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed maybe_change_log/1 to match atom-key :payload map, ensuring log_level from client options is applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix: ensures the log_level option from the client startup payload is correctly applied during connection initialization.
What is the current behavior?
The log_level value from client connection options is currently ignored.
The
maybe_change_logfunction expected the incoming payload to use string keys, but the payload fromServer.decode_startup_packetuses an atom-keyed map.Related (closed) issue: #209
What is the new behavior?
When connecting with:
Supavisor now set the requested level, and the following appears in logs:
[notice] Setting log level to :debugappears in the Supavisor logs.Additional context
Integration tests for this behavior are included in #770