Fixed #1112 Migrate to New NumPy Random Number Generator (RNG) API

[seanlaw]

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

• Fork, clone, and checkout the newest version of the code
• Create a new branch
• Make necessary code changes
• Install black (i.e., python -m pip install black or conda install -c conda-forge black)
• Install flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
• Install pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
• Run black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./ in the root stumpy directory
• Run flake8 --extend-exclude=.venv ./ in the root stumpy directory
• Run ./setup.sh dev && ./test.sh in the root stumpy directory
• Reference a Github issue (and create one if one doesn't already exist)

To Do List

1. Search for np.random
2. Replace np.random.rand(x) with pytest.RNG.random(x)
3. Replace np.random.rand(x*y).reshape(x,y) with pytest.RNG.random(size=(x, y))
4. Replace np.random.uniform(x, y, [z]) with pytest.RNG.uniform(x, y, size=z)
5. Replace np.random.permutation([x, y, z]) with pytest.RNG.permutation([x, y, z])
6. Replace np.random.randint(x, y, z) with pytest.RNG.integers(x, y, z)
7. Replace np.random.choice([x, y], l, replace=True) with pytest.RNG.choice([x, y], l, replace=True)
8. Replace np.random.normal(size=x) with pytest.RNG.normal(size=x)

[gitnotebooks]

Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1131

[seanlaw]

@NimaSarajpoor I've tested the migration on test_core.py as an initial trial run. Would you mind taking a look and providing any feedback before I do the same thing on the other tests?

[NimaSarajpoor]

@seanlaw
I've left just one comment for your consideration.

[seanlaw]

@NimaSarajpoor If it's okay with you, I'm going to add ~5 files at a time for you to incrementally review (there are 46 test files in total and I'll need to work on tutorials and other docs too).

[seanlaw]

Things are starting to get tricky. Previously, np.random.seed(seed) would set the seed for the global random number generator. However, with the new approach, we'll need to synchronize things across to naive.py (i.e., pass the RNG state). Extra care must be taken. Otherwise, things will fall out of sync and cause assertions to fail!

[seanlaw]

@NimaSarajpoor I added three new files for you to review