Fix issue #297 and #268, make proc inlining visit subblocks#302
Merged
aqjune-aws merged 17 commits intomainfrom Jan 14, 2026
Merged
Fix issue #297 and #268, make proc inlining visit subblocks#302aqjune-aws merged 17 commits intomainfrom
aqjune-aws merged 17 commits intomainfrom
Conversation
This patch fixes - Issue #297: BoogiePrelude.lean's `timedelta` was not updating `hours_i` - Issue #268: procedure inlining was reducing nondeterminism because it was missing havocs to output vars (this depends on how the "correctness" of procedure inlining is defined; if we say that procedure inlining is allowed to reduce nondeterminism, the original implementation was correct of course, but since this makes procedure inlining inherently unsound to use for deductive verification I chose to fix it.) - Procedure inlining wasn't visiting subblocks, which was fixed here. This required small updates in the function signature of `inlineCallCmd` and `callElimCmd` so that they receive Command rather than Statement. For these changes, checks are needed to confirm whether Python applications of interest are not affected.
joscoh
previously approved these changes
Jan 6, 2026
Contributor
Author
|
I will revisit the failing Python cases in this afternoon. |
Contributor
@aqjune-aws Maybe also see if #301 can help, if you have the bandwidth? |
Contributor
Author
|
The reason of the failure was that this extra I will add a parameter to the procedure inlining call so that functions to be excluded from inlining like |
joscoh
previously approved these changes
Jan 12, 2026
joscoh
reviewed
Jan 14, 2026
StrataTest/Languages/Python/expected/test_precondition_verification.expected
Show resolved
Hide resolved
joscoh
approved these changes
Jan 14, 2026
andrewmwells-amazon
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes
timedeltawas not updatinghours_iinlineCallCmdandcallElimCmdso that they receive Command rather than Statement.For these changes, checks are needed to confirm whether Python applications of interest are not affected.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.