Switch pubnet node data from Stellarbeat to Radar API property names#365
Switch pubnet node data from Stellarbeat to Radar API property names#365marta-lokhova merged 2 commits intomainfrom
Conversation
|
@copilot you did not update doc/measuring-transaction-throughput.md and topologies/theoretical-max-tps.json |
Fixed in 047d010 — updated |
Co-authored-by: marta-lokhova <9428003+marta-lokhova@users.noreply.github.com>
Co-authored-by: marta-lokhova <9428003+marta-lokhova@users.noreply.github.com>
047d010 to
67dc4c4
Compare
There was a problem hiding this comment.
Pull request overview
This PR renames all Stellarbeat API property names (sb_*) to Radar API property names (radar_*) across the codebase, as Stellarbeat is reaching end-of-life and being replaced by the Radar API at radar.withobsrvr.com.
Changes:
- Updated JSON sample file to use
radar_*property names, which drives F# type provider code generation - Updated all F# code to use generated properties with new names (
RadarHomeDomain,RadarGeoData,RadarIsValidating) - Updated documentation and topology files to reflect the new property naming convention
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/FSLibrary/json-type-samples/sample-network-data.json | Renamed all sb_* fields to radar_* in JSON type provider sample file |
| src/FSLibrary/StellarNetworkData.fs | Updated all generated property accesses and inline JSON to use Radar* naming |
| doc/measuring-transaction-throughput.md | Updated JSON example and description text to use radar_homeDomain |
| topologies/theoretical-max-tps.json | Renamed sb_homeDomain to radar_homeDomain in topology configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
drebelsky
left a comment
There was a problem hiding this comment.
Looks like it updates all the references to stellarbeat in this repo.
Stellarbeat is reaching EOL; the replacement is the Radar API (
radar.withobsrvr.com), which usesradar_*property names instead ofsb_*.Changes
sample-network-data.json: Rename allsb_*fields toradar_*(sb_homeDomain→radar_homeDomain,sb_geoData→radar_geoData,sb_isValidating→radar_isValidating, etc.). This file drives the F# JSON type provider, so its keys determine the generated property names.StellarNetworkData.fs: Update all generated property accesses to match:SbHomeDomain→RadarHomeDomainSbGeoData→RadarGeoDataSbIsValidating→RadarIsValidatingdoc/measuring-transaction-throughput.md: Update JSON example snippet and description text:sb_homeDomain→radar_homeDomain.topologies/theoretical-max-tps.json: Rename allsb_homeDomainfields toradar_homeDomain.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.