-
Notifications
You must be signed in to change notification settings - Fork 245
docs: Add Docker to Scaffold Stellar prerequisites #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this file shouldn't be modified. |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,6 +16,7 @@ Antes de comenzar, asegúrate de tener instalado lo siguiente: | |||||
| | [Rust & Cargo](https://www.rust-lang.org/tools/install) | Para escribir y compilar contratos inteligentes | `curl https://sh.rustup.rs -sSf \| sh` | | ||||||
| | [Node.js & npm](https://nodejs.org/) | Para el desarrollo del frontend | Descargar desde el sitio oficial | | ||||||
| | [Stellar CLI](https://github.com/stellar/stellar-cli) | Para construir, desplegar e interactuar con contratos inteligentes | [`Link for the repo`](https://github.com/stellar/stellar-cli) | | ||||||
| | [Docker](https://www.docker.com/get-started/) | Para ejecutar una red Stellar local mediante la imagen `stellar/quickstart` | [Descargar Docker Desktop](https://www.docker.com/products/docker-desktop/) | | ||||||
|
||||||
| | [Docker](https://www.docker.com/get-started/) | Para ejecutar una red Stellar local mediante la imagen `stellar/quickstart` | [Descargar Docker Desktop](https://www.docker.com/products/docker-desktop/) | | |
| | [Docker](https://www.docker.com/get-started/) | Para ejecutar una red Stellar local mediante la imagen `stellar/quickstart` | [Obtener Docker](https://docs.docker.com/get-docker/) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unnecessary to modify. Files in the /i18n directory should not be manually edited.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this file shouldn't be modified |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -18,6 +18,7 @@ Antes de comenzar, asegúrate de tener instalado lo siguiente: | |||||
| | [Rust & Cargo](https://www.rust-lang.org/tools/install) | Para escribir y compilar contratos inteligentes | `curl https://sh.rustup.rs -sSf \| sh` | | ||||||
| | [Node.js & npm](https://nodejs.org/) | Para el desarrollo frontend | Descarga desde el sitio oficial | | ||||||
| | [Stellar CLI](https://github.com/stellar/stellar-cli) | Para construir, desplegar e interactuar con contratos inteligentes | [`Link for the repo`](https://github.com/stellar/stellar-cli) | | ||||||
| | [Docker](https://www.docker.com/get-started/) | Para ejecutar una red Stellar local mediante la imagen `stellar/quickstart` | [Descargar Docker Desktop](https://www.docker.com/products/docker-desktop/) | | ||||||
|
||||||
| | [Docker](https://www.docker.com/get-started/) | Para ejecutar una red Stellar local mediante la imagen `stellar/quickstart` | [Descargar Docker Desktop](https://www.docker.com/products/docker-desktop/) | | |
| | [Docker](https://www.docker.com/get-started/) | Para ejecutar una red Stellar local mediante la imagen `stellar/quickstart` | [Obtener Docker](https://docs.docker.com/get-docker/) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unnecessary to modify. Files in the /i18n directory should not be manually edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install link text is “Download Docker Desktop”, which is Mac/Windows-specific and can be misleading for Linux users (who typically install Docker Engine). Consider using a more general install label/link (e.g., “Get Docker” pointing to Docker’s official install docs) so the prerequisite applies across platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems fine to me, either way. linux users are usually also aware enough to understand they may need to modify instructions like this. although, it is nice to be a bit more "universal" on our end, too