Conversation
|
Preview is available here: |
There was a problem hiding this comment.
Pull request overview
Adds a detailed design/implementation document describing a redesigned single-page transaction flow (Build/Simulate/Sign/Submit) and Soroban auth entry signing during simulation.
Changes:
- Document single-page stepper-based transaction flow with shared-link behavior and legacy route redirects.
- Specify planned components/state management for Build/Simulate/Sign/Submit, including Soroban-only Simulate step.
- Describe Soroban auth-entry signing UI/flow and related store/helpers/components.
Comments suppressed due to low confidence (3)
docs/new-transaction-flow.md:500
- Within the ASCII diagram, a few border lines end with a literal hyphen (e.g.
└──────────────────────────────-┘,└───────────────────────────────-┘), which looks like a typo and breaks the box drawing alignment in many renderers. Replace the trailing-with the matching box-drawing character (─) so the diagram renders cleanly.
│ │ └──────────────────────────────-┘ │ │
│ │ │ │
│ │ ┌ Simulated Result ─────────────┐ │ │
│ │ │ JSON code viewer (RPC response)│ │ │
│ │ └───────────────────────────────-┘ │ │
docs/new-transaction-flow.md:261
ClassicOperation.tsx:544is referenced as a line-number citation. Line numbers will drift over time and make the doc harder to keep accurate; prefer linking to the file/component name without a specific line number (or use a GitHub permalink if you need an exact reference).
**Reuses:** `SaveToLocalStorageModal` pattern from `ClassicOperation.tsx:544`,
`localStorageSavedTransactions` helper
docs/new-transaction-flow.md:844
- The document currently ends with
# Part 3: Import Transactionbut has no content under it. If Part 3 isn’t ready yet, consider removing this header or marking it explicitly as “(WIP)” with at least a short outline, so readers don’t assume content is missing.
# Part 3: Import Transaction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| users can navigate back to any completed step, but cannot skip forward. | ||
| Forward navigation always goes through the "Next" footer button | ||
|
|
||
| ### Shared link handling (MVP) |
| New structure — `page.tsx` renders `<BuildFlow />` directly; the `<Tabs />` | ||
| component contains nav links, not local state: | ||
|
|
||
| > **Tabs component concern:** The existing `src/components/Tabs/index.tsx` uses |
There was a problem hiding this comment.
@quietbits what do you think of this approach?
|
Preview is available here: |
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
2 participants
Readable view: https://github.com/stellar/laboratory/blob/df1be05fb9d42d09e66076050ce43e6c72bf538b/docs/new-transaction-flow.md