Migrate liquidity_pool_id.js file to TS#862
Conversation
|
Size Change: +275 B (+0.01%) Total Size: 3.53 MB
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the liquidity_pool_id.js file from JavaScript to TypeScript, maintaining the same functionality while adding type safety. The migration follows established patterns in the codebase for TypeScript conversions, using vitest for testing and generating appropriate type definitions.
Changes:
- Migrated
src/liquidity_pool_id.jsto TypeScript with proper type annotations - Added comprehensive TypeScript test file using vitest
- Generated type definition file with complete method signatures
- Updated
.gitignoreto include TypeScript build artifacts
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/liquidity_pool_id.ts |
New TypeScript implementation with type annotations and XDR type workarounds for compatibility |
src/liquidity_pool_id.js |
Removed old JavaScript implementation |
test/unit/liquidity_pool_id.test.ts |
New comprehensive test suite using vitest framework |
type_validation/liquidity_pool_id.d.ts |
Generated type definitions matching the implementation |
type_validation/strkey.d.ts |
Alphabetically sorted union type members for consistency |
.gitignore |
Added tsconfig.tsbuildinfo for TypeScript build cache |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.