Skip to content

[6.x] Fix Bard Link Toolbar #13306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
duncanmcclean wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[6.x] Fix Bard Link Toolbar #13306

duncanmcclean wants to merge 6 commits into from
+20 −7

Conversation

@duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Dec 10, 2025 •
edited
Loading

This pull request fixes various with the Bard Link Toolbar:

  • Corrects icon names
  • Fixes an issue where selecting a link type would close the popover.
    • This was happening due to the click event originating in the Combobox's portal, which is considered "outside" of the Popover.
    • This PR fixes it by adding a new closeOnOutsideClick prop to the Popover, like we used in v5.
  • Fixes an error when opening the entry selector
    • This was due to an added conditional around the existing button, meaning it wouldn't be rendered in some conditions.
    • This PR fixes it by adding a new openSelector method instead.

Fixes #13195
Fixes #13366

@duncanmcclean
Update icon references
fbe79fe
@duncanmcclean
Prevent popover closing when clicking combobox items
599d78a 
The Combobox options are rendered in their own portal, which triggers the Popover's "focus-outside" event.

We need to cancel the popover event when the user clicks a combobox option.
@duncanmcclean
Avoid needing to "click" a ref to open relationship selector
9136c61
@duncanmcclean duncanmcclean linked an issue Dec 10, 2025 that may be closed by this pull request
[6.x] Linking in Bard not working #13195
Open
@jackmcdade
Copy link
Member

jackmcdade commented Dec 10, 2025

CleanShot.2025-12-10.at.17.30.46.mp4

Seems to still need a bit 'o love 🤔

@duncanmcclean
Copy link
Member Author

duncanmcclean commented Dec 11, 2025

@jackmcdade Better now?

@duncanmcclean duncanmcclean linked an issue Dec 18, 2025 that may be closed by this pull request
[6.x] Link fieldtype throws Javascript error #13366
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[6.x] Link fieldtype throws Javascript error [6.x] Linking in Bard not working

3 participants

@duncanmcclean @jackmcdade