[SFW Switch] Support for Hot or Not and Stash Battle#676
Closed
Servbot91 wants to merge 3 commits intostashapp:mainfrom
Closed
[SFW Switch] Support for Hot or Not and Stash Battle#676Servbot91 wants to merge 3 commits intostashapp:mainfrom
Servbot91 wants to merge 3 commits intostashapp:mainfrom
Conversation
Integration for additional plugins such as Stash Battle and Hot or Not. Preserves integrity of the plugin and since it is CSS, it has no impact if the plugins are not installed.
Bump for additional plugin support: Hot or Not and Stash Battle
Bump version from 1.3 to 1.4
|
This pull request has been mentioned on Stash Forum. There might be relevant details there: |
Contributor
|
Generally I'm fine with this, but my preferred approach would be to inject them via another .css file, something like |
Contributor
Author
I like this idea and will send another PR with this suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to add support for Stash Battle and Hot or Not. They are popular and well developed plugins and display content outside the scope of the initial SFW release. Since this is CSS, it has no impact if the user does not have the plugins installed. SFW plugin continues to function correctly with and without the plugins installed.