chore(deps): upgrade electron and the use of node to 24#1554
Open
chore(deps): upgrade electron and the use of node to 24#1554
Conversation
Collaborator
Author
|
/build-test |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the project to use Node.js 24 and Electron 40.1.0, taking advantage of the Electron 40 release which added support for Node.js 24. The upgrade ensures the project stays current with the latest stable versions of these critical dependencies.
Changes:
- Upgraded Node.js requirement from 22 to 24 across all configuration files
- Upgraded Electron from 39.2.7 to 40.1.0
- Updated @types/node from ^22.15.21 to ^24.1.0 along with all transitive type dependencies
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated Node.js engine constraint to 24.x, Electron to 40.1.0, and @types/node to ^24.1.0 |
| pnpm-lock.yaml | Comprehensive lockfile update with all dependency resolutions for Node 24 types and Electron 40 |
| .nvmrc | Updated Node version specification from 22 to 24 for nvm users |
| .github/workflows/renovate-post-upgrade.yml | Updated CI workflow Node version to 24 |
| .github/actions/setup/action.yaml | Updated composite action to use Node 24, which cascades to all other workflows |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Contributor
Build Artifacts for PR #1554
Download artifacts from workflow run Version:
|
samuv
force-pushed
the
upgrade-electron
branch
from
940bc5a to
11f607e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new version of electron 40 it is possible to use node 24, in this PR we tackle the upgrade for both