Skip to content

feat: show if current version is latest one#1547

Open
peppescg wants to merge 3 commits intomainfrom
show-latest-version-info
Open

feat: show if current version is latest one#1547
peppescg wants to merge 3 commits intomainfrom
show-latest-version-info

Conversation

@peppescg
Copy link
Collaborator

@peppescg peppescg commented Feb 3, 2026

Screenshot 2026-02-03 at 13 06 42

@peppescg peppescg self-assigned this Feb 3, 2026
Copilot AI review requested due to automatic review settings February 3, 2026 12:08
Copilot AI reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a UI indicator in Settings to show when the installed Desktop UI version matches the latest available version.

Changes:

  • Extended AppVersionInfo with a new isLatestVersion boolean.
  • Derived isLatestVersion in useAppVersion() and displayed a “latest version” label in the Version settings tab.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
renderer/src/common/hooks/use-app-version.ts Adds isLatestVersion to the version info returned by the React Query hook.
renderer/src/common/components/settings/tabs/version-tab.tsx Updates the Desktop UI version badge to optionally show a “latest version” label.

peppescg and others added 2 commits February 3, 2026 14:38
@peppescg @cursoragent
fix: address PR review comments for isLatestVersion feature
6d9689d 
- Fix version comparison to use !isNewVersionAvailable instead of
  direct string equality to avoid issues with 'v' prefix mismatch
- Fix spacing in "(latest version)" label
- Add tests for isLatestVersion display behavior
- Update test mocks to include isLatestVersion property

Co-authored-by: Cursor <cursoragent@cursor.com>
@peppescg @cursoragent
refactor: remove redundant isLatestVersion property
173afd3 
Use !isNewVersionAvailable directly instead of maintaining
a separate isLatestVersion field, simplifying the interface
and reducing redundancy.

Co-authored-by: Cursor <cursoragent@cursor.com>
@peppescg peppescg enabled auto-merge (squash) February 3, 2026 16:16
@samuv
Copy link
Collaborator

samuv commented Feb 4, 2026

Instead of the text, wouldn’t it be better to use a green tag on the side that just says “latest”?
I feel like the text in parentheses doesn’t have a lot of impact

@peppescg
Copy link
Collaborator Author

peppescg commented Feb 4, 2026

Instead of the text, wouldn’t it be better to use a green tag on the side that just says “latest”? I feel like the text in parentheses doesn’t have a lot of impact

yeah you're right I don't have a strong opinion.
I also forgot to share this PR 😆 cause I am not totally convinced about it (probably I would move the default update flow to manual update, cause also if the user do not wants to upgrade, the next time that will restart the app he will find the new one, so he doesn't have the full control...and moving the default flow to manual there will be always the notification and icon for new update available, and in this case you shouldn't need a latest label)

@jtenniswood we can add the a green tag on the right side with latest, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@peppescg peppescg

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peppescg @samuv