docs: clarify that MCP tools require glob patterns to disable #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
355
to
361
| #### Glob patterns | ||
|
|
||
| The glob pattern uses simple regex globbing patterns. | ||
|
|
||
| - `*` matches zero or more of any character | ||
| - `?` matches exactly one character | ||
| - All other characters match literally |
Collaborator
There was a problem hiding this comment.
That is what this section already states, so instead maybe we should just reword this a bit to be more clear?
There was a problem hiding this comment.
I literally just beat my head against this. This would have saved me over an hour of tweaking.
3mdistal
force-pushed
the
clarify-mcp-tool-naming
branch
from
32d4cd9 to
0700c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
server-name_tool-name"my-mcp*") are needed instead of exact server namesRelated issues: #5373, #2953
Users setting
"my-mcp": falsein their tools config expect it to disable all tools from that MCP server, but it doesn't work because the actual tool names are prefixed (e.g.,my-mcp_search). This note makes the naming convention explicit.