Clarify what is doing the overriding of settings#1004
Open
larrywest wants to merge 1 commit intospring-cloud:mainfrom
Open
Clarify what is doing the overriding of settings#1004larrywest wants to merge 1 commit intospring-cloud:mainfrom
larrywest wants to merge 1 commit intospring-cloud:mainfrom
Conversation
If I am reading this correctly, the existing two lines flip the perspective of what is doing the overriding from “subject/actor is remote (e.g., config-service) overriding local settings” (in the property names) to “subject/actor is local settings overriding remote ones” (in the text) within each line: Existing: ``` * `spring.cloud.config.overrideNone=true`: Override from any local property source. * `spring.cloud.config.overrideSystemProperties=false`: Only system properties, command line arguments, and environment variables (but not the local config files) should override the remote settings. ``` My change aims to clarify by not re-using the verb "override", which is in the property names. It also removes "should", which I find puzzling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I am reading this correctly, the existing two lines flip the perspective of what is doing the overriding from “subject/actor is remote (e.g., config-service) overriding local settings” (in the property names) to “subject/actor is local settings overriding remote ones” (in the text) within each line:
Existing:
My change aims to clarify by not re-using the verb "override", which is in the property names. It also removes "should", which I think distracts.