This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Fix: Do Not Retry on 404 HTTP Status Code#239
Merged
gitrema merged 1 commit intospotify:masterfrom Jan 8, 2025
Merged
Conversation
danaospo
force-pushed
the
remove-retry-on-404
branch
from
78de809 to
a3e197c
Compare
danaospo
changed the title
gitrema
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the retry logic in
SPTDataLoaderto exclude 404 Not Found from retryable HTTP status codes. Previously, 404 responses were retried by default, which could lead to unnecessary network requests and delays.