This repository was archived by the owner on Jan 17, 2019. It is now read-only.
Move layout logic into the collection view factory#331
Open
cerihughes wants to merge 6 commits intospotify:masterfrom
Open
Move layout logic into the collection view factory#331cerihughes wants to merge 6 commits intospotify:masterfrom
cerihughes wants to merge 6 commits intospotify:masterfrom
Conversation
… move-layout-logic-into-the-view
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
=========================================
- Coverage 80.57% 80.2% -0.38%
=========================================
Files 84 84
Lines 5659 4500 -1159
=========================================
- Hits 4560 3609 -951
+ Misses 1099 891 -208
Continue to review full report at Codecov.
|
krris
approved these changes
Apr 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a collection view layout in the collection view factory when we create the collection view, and absolve the view controller of that responsibility. The VC now also doesn't need to create a "temporary"
UICollectionViewLayoutclass for the collection view.