ci: composite actions for setting up dependencies for macOS and Linux runners by ExplorerRay · Pull Request #691 · solvcon/modmesh

ExplorerRay · 2026-03-12T11:47:35Z

I just add setup_macOS and setup_Linux composite actions for dependency and use them in devbuild and lint workflows to solve part of #677.

These two composite actions have one input called workflow to decide whether some packages should be installed or not.
For example, clang-tidy is only needed when doing lint.

Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw>

ExplorerRay · 2026-03-12T12:02:49Z

.github/workflows/devbuild.yml

-          echo "pyside6 path: ${PYSIDE6_PATH}"
-          rm -rf ${PYSIDE6_PATH}/Qt/lib/*.framework
-          # maunally add homebrew's Qt rpath to PySide6
-          install_name_tool -add_rpath $(qtpaths --install-prefix)/lib ${PYSIDE6_PATH}/QtWidgets.abi3.so


I want to mention that I remove some lines like these (L498 - 500), I originally want to fix it if the CI fails.
However, it works without any error, so I think it's okay to remove these things.

Please keep the lines. They are hard-learnt know-how. It will be hard to recover the knowledge 5 years after we drop them from the file.

But you can keep them commented out in the file if not wanting to have them active. If you can find the PR originally added the lines, it will be great to add it to the comment.

yungyuc

Use all-lower-case for directory names: setup_linux and setup_macos. It is ambiguous to mix lower and upper cases.
Keep the lines for mac install_name_tool. They are hard-learnt know-how.

yungyuc · 2026-03-12T13:09:45Z

.github/actions/setup_Linux/action.yml

@@ -0,0 +1,151 @@
+name: Setup modmesh CI dependencies on Linux


"Setup" is not a verb (at least was not one). Use "Set up" like what you wrote in the next line.

yungyuc · 2026-03-12T13:10:30Z

.github/actions/setup_Linux/action.yml

@@ -0,0 +1,151 @@
+name: Setup modmesh CI dependencies on Linux
+description: Sets up the necessary dependencies for running CI tests on Github action Linux runners


Use correct tense. It's "Set up", not "Sets up".

yungyuc · 2026-03-12T13:16:31Z

.github/workflows/devbuild.yml

-          echo "pyside6 path: ${PYSIDE6_PATH}"
-          rm -rf ${PYSIDE6_PATH}/Qt/lib/*.framework
-          # maunally add homebrew's Qt rpath to PySide6
-          install_name_tool -add_rpath $(qtpaths --install-prefix)/lib ${PYSIDE6_PATH}/QtWidgets.abi3.so


Please keep the lines. They are hard-learnt know-how. It will be hard to recover the knowledge 5 years after we drop them from the file.

But you can keep them commented out in the file if not wanting to have them active. If you can find the PR originally added the lines, it will be great to add it to the comment.

yungyuc · 2026-03-12T13:18:20Z

@terrychan999 @chestercheng please help review the changes. It looks good to me but it's too long for me to be sure that everything is right. More eye balls help.

ExplorerRay · 2026-03-12T13:43:19Z

Use all-lower-case for directory names: setup_linux and setup_macos. It is ambiguous to mix lower and upper cases.

About the directory name, I use these cases because Linux and macOS are defined in runner.os (ref).

With this, we can further improve the following code into another one refers to this discussion.

- name: setup dependencies for Linux
    if: runner.os == 'Linux'
    uses: ./.github/actions/setup_Linux
    with:
      workflow: 'lint'

  - name: setup dependencies for macOS
    if: runner.os == 'macOS'
    uses: ./.github/actions/setup_macOS
    with:
      workflow: 'lint'

- name: setup dependencies
    uses: jenseng/dynamic-uses@v1
    with:
      uses: ./.github/actions/setup_${{ runner.os }}
      with: 
        workflow: 'lint'

yungyuc · 2026-03-12T13:52:31Z

Use all-lower-case for directory names: setup_linux and setup_macos. It is ambiguous to mix lower and upper cases.

About the directory name, I use these cases because Linux and macOS are defined in runner.os (ref).

With this, we can further improve the following code into another one refers to this discussion.
- name: setup dependencies for Linux
    if: runner.os == 'Linux'
    uses: ./.github/actions/setup_Linux
    with:
      workflow: 'lint'

  - name: setup dependencies for macOS
    if: runner.os == 'macOS'
    uses: ./.github/actions/setup_macOS
    with:
      workflow: 'lint'
- name: setup dependencies
    uses: jenseng/dynamic-uses@v1
    with:
      uses: ./.github/actions/setup_${{ runner.os }}
      with: 
        workflow: 'lint'

Directory names of mixed cases are not an improvement. The directory names do not need to be identical to variable contents.

Let's use all-lower-case directory.

ExplorerRay · 2026-03-12T14:43:45Z

Use all-lower-case for directory names: setup_linux and setup_macos. It is ambiguous to mix lower and upper cases.

Keep the lines for mac install_name_tool. They are hard-learnt know-how.

I just fixed them. Please review again. Thanks.

yungyuc

LGTM. @terrychan999 @chestercheng please help review.

chestercheng

@ExplorerRay thanks for the refactor.
Moving the environment setup into composite actions helps reduce duplication and makes the workflows easier to maintain.

chestercheng · 2026-03-13T10:03:57Z

.github/actions/setup_linux/action.yml

+runs:
+  using: composite
+  steps:
+    - uses: actions/checkout@v6


The workflow already checkout the repo before. This step may be redundant.

chestercheng · 2026-03-13T10:04:19Z

.github/actions/setup_macos/action.yml

+runs:
+  using: composite
+  steps:
+    - uses: actions/checkout@v6


Same as above

I just fixed them and CI worked well.

Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw>

yungyuc · 2026-03-13T14:04:32Z

@chestercheng make a global comment again if you are good with the change.

chestercheng

LGTM

ci: add composite action for lint setup dependency based on OS

8fc01b0

Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw>

ExplorerRay mentioned this pull request Mar 12, 2026

Reduce duplication by sharing common steps between GitHub Actions #677

Open

ExplorerRay commented Mar 12, 2026

View reviewed changes

yungyuc requested changes Mar 12, 2026

View reviewed changes

yungyuc assigned ExplorerRay Mar 12, 2026

yungyuc added the build Build system and automation label Mar 12, 2026

yungyuc requested review from chestercheng and terrychan999 March 12, 2026 13:18

ExplorerRay force-pushed the ci-composite branch 2 times, most recently from 7e881c0 to 6c48f44 Compare March 12, 2026 14:18

yungyuc approved these changes Mar 13, 2026

View reviewed changes

chestercheng suggested changes Mar 13, 2026

View reviewed changes

ci: use composite action for devbuild on ubuntu & macos runner

9cb34cf

Signed-off-by: Ray Huang <bjhuang@cs.nycu.edu.tw>

ExplorerRay force-pushed the ci-composite branch from 6c48f44 to 9cb34cf Compare March 13, 2026 10:46

chestercheng approved these changes Mar 13, 2026

View reviewed changes

		@@ -0,0 +1,151 @@
		name: Setup modmesh CI dependencies on Linux

		@@ -0,0 +1,151 @@
		name: Setup modmesh CI dependencies on Linux
		description: Sets up the necessary dependencies for running CI tests on Github action Linux runners

Conversation

ExplorerRay commented Mar 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc commented Mar 12, 2026

Uh oh!

ExplorerRay commented Mar 12, 2026

Uh oh!

yungyuc commented Mar 12, 2026

Uh oh!

ExplorerRay commented Mar 12, 2026

Uh oh!

yungyuc left a comment

Choose a reason for hiding this comment

Uh oh!

chestercheng left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc commented Mar 13, 2026

Uh oh!

chestercheng left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yungyuc left a comment •

edited

Loading